CFE-885:Feature route external certificate validation #407
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -103,7 +103,7 @@ func (o *OpenShiftAPIServer) Validate() error { | |
|
|
||
| // RunAPIServer takes the options, starts the API server and waits until stopCh is closed or initial listening fails. | ||
| func (o *OpenShiftAPIServer) RunAPIServer(stopCh <-chan struct{}) error { | ||
| if err := features.InitializeFeatureGates(feature.DefaultMutableFeatureGate, configv1.SelfManaged, configv1.FeatureGateRouteExternalCertificate); err != nil { | ||
|
Contributor
There was a problem hiding this comment. Assuming Hypershift runs this instance of the API server, how does it specify its own profile?
Member
Author
There was a problem hiding this comment. @deads2k suggested always using self-managed here.
Contributor
There was a problem hiding this comment. please add a comment explaining
Contributor
There was a problem hiding this comment.
Arbitrary choice since this binary doesn't care and teaching the operand about hypershift is not likely to end well. |
||
| return err | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand how these adapters (with empty
RouteValidationOptions{}) relate to the strategy (which initializes itsRouteValidationOptionsobject), so I have to defer to the openshift-apiserver maintainers to verify that the register code and the strategy code are correctly handlingRouteValidationOptions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked that all other resources in this file are also getting registered with an empty struct. e.g
I'm also unsure whether they are used somewhere or only meant to check whether all validators are correctly registered through unit tests. I'll wait for apiserver team's suggestion on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stlaz could you check if these changes look good from openshift-apiserver viewpoint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used by units in
openshift-apiserver/pkg/api/validation/validation_test.go
Line 1 in 12686d8