Bug 2037075: Add CSI VolumeSource to build types by adambkaplan · Pull Request #264 · openshift/openshift-apiserver

adambkaplan · 2021-12-20T16:45:34Z

Augment BuildVolumeSource to inlcude the CSI source type and volume source.
Re-run make update to generate deep copies, conversions, and openapi updates.
Add validation for build CSI volume sources to ensure that the driver name is set and valid.

Update openshift/api to include the new CSI volume source type for Builds.

- Augment BuildVolumeSource to inlcude the CSI source type and volume source. - Re-run `make update` to generate deep copies, conversions, and openapi updates. - Add validation for build CSI volume sources to ensure that the driver name is set and valid.

adambkaplan · 2022-01-04T20:40:32Z

pkg/openapi/zz_generated.openapi.go

 							Type:        []string{"string"},
 							Format:      "",
-							Enum:        []interface{}{"Container", "PersistentVolumeClaim", "Pod"}},
+							Enum:        []interface{}{"Container", "PersistentVolumeClaim", "Pod", "openshift.io/Image", "openshift.io/ImageStream"}},


fyi @dmage @ricardomaraschini

Any ideas why it wasn't there before and what has changed?

Odd to see this myself, since openshift/api had been updated recently before this PR merged.

openshift-ci · 2022-01-04T20:44:16Z

@adambkaplan: This pull request references Bugzilla bug 2037075, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jitendar-singh

Details

In response to this:

Bug 2037075: Add CSI VolumeSource to build types

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adambkaplan · 2022-01-04T20:44:46Z

/assign @tkashem

/cc @jkhelil

jkhelil · 2022-01-05T08:00:28Z

/test e2e-aws-upgrade
/test e2e-cmd

openshift-ci · 2022-01-05T09:54:32Z

@adambkaplan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

gabemontero · 2022-01-05T21:44:53Z

/lgtm

jkhelil · 2022-01-06T07:42:32Z

/lgtm

tkashem · 2022-01-06T15:22:19Z

/approve

openshift-ci · 2022-01-06T15:25:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, gabemontero, jkhelil, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [tkashem]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2022-01-06T15:26:13Z

@adambkaplan: Some pull requests linked via external trackers have merged:

openshift/openshift-apiserver#264

The following pull requests linked via external trackers have not merged:

openshift/openshift-controller-manager#214 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2037075 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 2037075: Add CSI VolumeSource to build types

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 20, 2021

adambkaplan mentioned this pull request Dec 20, 2021

BUILD-275: add support for build csi volume source #262

Closed

openshift-ci bot requested review from mfojtik and soltysh December 20, 2021 16:46

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 22, 2021

adambkaplan added 2 commits January 4, 2022 15:29

bump(openshift/api):

71b05b7

Update openshift/api to include the new CSI volume source type for Builds.

adambkaplan force-pushed the build-275-csi-volumes branch from da36a4b to 6e4727e Compare January 4, 2022 20:37

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 4, 2022

adambkaplan changed the title ~~WIP - BUILD-275: Add CSI VolumeSource to build types~~ BUILD-275: Add CSI VolumeSource to build types Jan 4, 2022

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 4, 2022

adambkaplan commented Jan 4, 2022

View reviewed changes

adambkaplan changed the title ~~BUILD-275: Add CSI VolumeSource to build types~~ Bug 2037075: Add CSI VolumeSource to build types Jan 4, 2022

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 4, 2022

openshift-ci bot requested a review from jitendar-singh January 4, 2022 20:44

openshift-ci bot assigned tkashem Jan 4, 2022

openshift-ci bot requested a review from jkhelil January 4, 2022 20:44

adambkaplan mentioned this pull request Jan 4, 2022

Bug 2037075: Add Support for Build CSI Volume Sources openshift/openshift-controller-manager#214

Merged

openshift-ci bot assigned gabemontero Jan 5, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2022

jkhelil approved these changes Jan 6, 2022

View reviewed changes

openshift-ci bot assigned jkhelil Jan 6, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2022

openshift-merge-robot merged commit 2bd52b8 into openshift:master Jan 6, 2022

openshift-ci bot mentioned this pull request Jan 21, 2022

Bug 2037075: Verify Builds with CSI Volume Sources openshift/origin#26646

Merged

Conversation

adambkaplan commented Dec 20, 2021

Uh oh!

adambkaplan Jan 4, 2022

Choose a reason for hiding this comment

Uh oh!

dmage Jan 4, 2022

Choose a reason for hiding this comment

Uh oh!

dmage Jan 4, 2022

Choose a reason for hiding this comment

Uh oh!

adambkaplan Jan 5, 2022

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jan 4, 2022

Uh oh!

adambkaplan commented Jan 4, 2022

Uh oh!

jkhelil commented Jan 5, 2022

Uh oh!

openshift-ci bot commented Jan 5, 2022

Uh oh!

gabemontero commented Jan 5, 2022

Uh oh!

jkhelil commented Jan 6, 2022

Uh oh!

tkashem commented Jan 6, 2022

Uh oh!

openshift-ci bot commented Jan 6, 2022

Uh oh!

openshift-ci bot commented Jan 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Comments