Skip to content

Revert "Merge pull request #153 from p0lyn0mial/pick-up-tcp-timeout"#156

Closed
deads2k wants to merge 1 commit intoopenshift:masterfrom
deads2k:revert-01
Closed

Revert "Merge pull request #153 from p0lyn0mial/pick-up-tcp-timeout"#156
deads2k wants to merge 1 commit intoopenshift:masterfrom
deads2k:revert-01

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Nov 5, 2020

This reverts commit 5bb8070, reversing
changes made to 033ead3.

reverts #153

This is one of two changes that were in the level that suddenly permafailed e2e-serial. However, 153 did pass serial, so this is unlikely to be it.

@deads2k
Revert "Merge pull request openshift#153 from p0lyn0mial/pick-up-tcp-…
c130146 
…timeout"

This reverts commit 5bb8070, reversing
changes made to 033ead3.
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 5, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2020
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 5, 2020

@deads2k: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-cmd c130146 link /test e2e-cmd
ci/prow/e2e-aws-serial c130146 link /test e2e-aws-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor Author

deads2k commented Nov 5, 2020

Wasn't this one. it failed on OOMKill

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 8, 2020

@deads2k: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2020
@deads2k deads2k closed this Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coreydaley coreydaley Awaiting requested review from coreydaley

@gabemontero gabemontero Awaiting requested review from gabemontero

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@deads2k @openshift-ci-robot @openshift-merge-robot