Bug 1844471: bump kubernetes to 1.19.0-rc.2 #132

p0lyn0mial · 2020-08-26T11:17:14Z

No description provided.

…faulting for pod

p0lyn0mial · 2020-08-28T15:23:25Z

/test e2e-aws

p0lyn0mial · 2020-08-28T16:41:22Z

/test e2e-aws-serial

p0lyn0mial · 2020-08-28T17:13:08Z

it looks like e2e-aws is broken with exec: python2: not found - should be fixed by https://bugzilla.redhat.com/show_bug.cgi?id=1873414

p0lyn0mial · 2020-08-31T20:33:33Z

/retest

p0lyn0mial · 2020-09-01T06:33:36Z

/retest

…efore decorating

sttts · 2020-09-02T12:37:56Z

pkg/apps/apis/apps/v1/conversion.go

 	if in.Pre != nil {
 		out.Pre = &newer.LifecycleHook{}
-		if err := Convert_v1_LifecycleHook_To_apps_LifecycleHook(in.Pre, out.Pre, s); err != nil {
+		if err := Convert_v1_LifecycleHook_To_apps_LifecycleHook(in.Pre, out.Pre, nil); err != nil {


I will revert.

pkg/build/apis/build/v1/conversion.go

p0lyn0mial · 2020-09-02T13:48:26Z

pkg/apps/apis/apps/v1/conversion.go

 	if in.Post != nil {
 		out.Post = &newer.LifecycleHook{}
-		if err := Convert_v1_LifecycleHook_To_apps_LifecycleHook(in.Post, out.Post, s); err != nil {
+		if err := Convert_v1_LifecycleHook_To_apps_LifecycleHook(in.Post, out.Post, nil); err != nil {


@sttts what about the others in this pkg? I think I'm going to revert them as well.

p0lyn0mial · 2020-09-02T16:33:29Z

/retest

p0lyn0mial · 2020-09-03T06:22:16Z

/retest

p0lyn0mial · 2020-09-03T08:41:33Z

/retest

p0lyn0mial · 2020-09-03T10:29:31Z

/retest

p0lyn0mial · 2020-09-07T07:16:24Z

/retry

p0lyn0mial · 2020-09-07T07:51:21Z

/test e2e-cmd

sttts · 2020-09-07T07:54:23Z

/approve

sttts · 2020-09-07T07:55:32Z

/lgtm

openshift-ci-robot · 2020-09-07T07:56:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sttts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sttts · 2020-09-07T07:56:02Z

/bugzilla-refresh

openshift-ci-robot · 2020-09-07T08:02:00Z

@p0lyn0mial: This pull request references Bugzilla bug 1844471, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1844471: bump kubernetes to 1.19.0-rc.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-09-07T09:34:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-07T09:47:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-07T11:18:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-09-07T12:53:04Z

@p0lyn0mial: All pull requests linked via external trackers have merged:

openshift/openshift-apiserver#132

Bugzilla bug 1844471 has been moved to the MODIFIED state.

In response to this:

Bug 1844471: bump kubernetes to 1.19.0-rc.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mfojtik and others added 16 commits August 26, 2020 12:56

security: add object meta to pod spec validation

79255af

IMPORTANT: NEED REVIEW: Audit options refactored upstream

2e2920a

api: adjust compatibility test to new pod validation

944393e

update generated

61fa0a3

BORING: build: fix gitlab push test conversion

3aba14e

BORING: remove cruft in apps test

41fd0e3

sweep usage of legacy conversion in code

9f9f266

BORING: update bootstrap_cluster_roles.yaml

7f6bb8b

INTERESTING: TestPodSpecNodeSelectorUpdateDisallowed required more de…

5197be6

…faulting for pod

Generate conversions for dockerpre012 and docker10

7dc1d9a

Install conversions for dockerpre012 and docker10

e938f1b

BORING: apps: fix rolling deployment strategy params conversion

846373e

Support legacy DockerImage versions

f23a48d

apps: fix nil scop in strategy conversions

b78bd3b

build: remove custom schema in strategyrestrictions

d857ce4

build: add conversion from url values to build log options

c7dfd6b

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2020

openshift-ci-robot requested review from coreydaley and stlaz August 26, 2020 11:17

p0lyn0mial force-pushed the rebase-19-from-mfojtik branch from 6e73eeb to f68bb99 Compare August 26, 2020 11:37

This was referenced Aug 28, 2020

fix filtering out CustomResourceQuota paths from OpenAPI openshift/kubernetes-apiserver#12

Merged

UPSTREAM: <carry>: openshift-apiserver: ignored namespace lifecycle resources openshift/kubernetes-apiserver#13

Merged

p0lyn0mial mentioned this pull request Sep 1, 2020

WIP: bump kubernetes to 1.19.0-rc.2 #126

Closed

p0lyn0mial added 2 commits September 1, 2020 12:53

bump(*): kubernetes-1.19.0-rc.2

e9678d3

imagestream: unpack the object if it's comming from the watch cache b…

f747ca3

…efore decorating

sttts reviewed Sep 2, 2020

View reviewed changes

pkg/build/apis/build/v1/conversion.go Outdated Show resolved Hide resolved

sttts reviewed Sep 2, 2020

View reviewed changes

pkg/build/apis/build/v1/conversion.go Outdated Show resolved Hide resolved

p0lyn0mial commented Sep 2, 2020

View reviewed changes

review changes

c3310f0

p0lyn0mial changed the title ~~WIP:mfojtik: bump kubernetes to 1.19.0-rc.2~~ bump kubernetes to 1.19.0-rc.2 Sep 2, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2020

openshift-ci-robot assigned sttts Sep 7, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2020

p0lyn0mial changed the title ~~bump kubernetes to 1.19.0-rc.2~~ Bug 1844471: bump kubernetes to 1.19.0-rc.2 Sep 7, 2020

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 7, 2020

openshift-merge-robot merged commit f564a2a into openshift:master Sep 7, 2020

openshift-ci-robot mentioned this pull request Sep 8, 2020

Bug 1844471: Bump openshift apiserver to 1 19 #134

Merged

Bug 1844471: bump kubernetes to 1.19.0-rc.2 #132

Bug 1844471: bump kubernetes to 1.19.0-rc.2 #132

Uh oh!

Conversation

p0lyn0mial commented Aug 26, 2020

Uh oh!

p0lyn0mial commented Aug 28, 2020

Uh oh!

p0lyn0mial commented Aug 28, 2020

Uh oh!

p0lyn0mial commented Aug 28, 2020

Uh oh!

p0lyn0mial commented Aug 31, 2020

Uh oh!

p0lyn0mial commented Sep 1, 2020

Uh oh!

sttts Sep 2, 2020

Choose a reason for hiding this comment

Uh oh!

p0lyn0mial Sep 2, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

p0lyn0mial Sep 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

p0lyn0mial commented Sep 2, 2020

Uh oh!

p0lyn0mial commented Sep 3, 2020

Uh oh!

p0lyn0mial commented Sep 3, 2020

Uh oh!

p0lyn0mial commented Sep 3, 2020

Uh oh!

p0lyn0mial commented Sep 7, 2020

Uh oh!

p0lyn0mial commented Sep 7, 2020

Uh oh!

sttts commented Sep 7, 2020

Uh oh!

sttts commented Sep 7, 2020

Uh oh!

openshift-ci-robot commented Sep 7, 2020

Uh oh!

sttts commented Sep 7, 2020

Uh oh!

openshift-ci-robot commented Sep 7, 2020

Uh oh!

openshift-bot commented Sep 7, 2020

Uh oh!

openshift-bot commented Sep 7, 2020

Uh oh!

openshift-bot commented Sep 7, 2020

Uh oh!

openshift-ci-robot commented Sep 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

p0lyn0mial Sep 2, 2020 •

edited

Loading