Skip to content

Move the cluster-cidr assignment to the correct configs#9866

Closed
mgleung wants to merge 1 commit intoopenshift:release-3.10from
mgleung:calico-pass-cluster-cidr-to-proxy-3.10
Closed

Move the cluster-cidr assignment to the correct configs#9866
mgleung wants to merge 1 commit intoopenshift:release-3.10from
mgleung:calico-pass-cluster-cidr-to-proxy-3.10

Conversation

@mgleung
Copy link
Contributor

@mgleung mgleung commented Aug 31, 2018

As per #8099, "connections to nodeports only succeed if the pod backing the nodeport service is running on the host being hit. So requests are not forwarded to other nodes if the pod is running there.

This PR resolves the issue by passing Cluster CIDR to kube-proxy, which implements the nececssary iptables rules."

This PR replicates those changes in the new location of the node config template.

This is a copy of #9863

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 31, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mgleung
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mtnbikenc

If they are not already assigned, you can assign the PR to them by writing /assign @mtnbikenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 31, 2018
@papr-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@sdodson
Copy link
Member

sdodson commented Sep 4, 2018

/assign @openshift/sig-networking

@mgleung mgleung force-pushed the calico-pass-cluster-cidr-to-proxy-3.10 branch from 58767fa to 54e4170 Compare September 14, 2018 01:11
@mgleung mgleung force-pushed the calico-pass-cluster-cidr-to-proxy-3.10 branch from 54e4170 to 6ee532a Compare September 18, 2018 00:42
@sdodson
Copy link
Member

sdodson commented Sep 21, 2018

/ok-to-test

@openshift-ci-robot openshift-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 21, 2018
@mgleung
Copy link
Contributor Author

mgleung commented Sep 25, 2018

/retest

1 similar comment
@mgleung
Copy link
Contributor Author

mgleung commented Sep 25, 2018

/retest

@mgleung
Copy link
Contributor Author

mgleung commented Sep 25, 2018

Closing since #10198 was merged instead.

@mgleung mgleung closed this Sep 25, 2018
@mgleung mgleung deleted the calico-pass-cluster-cidr-to-proxy-3.10 branch September 26, 2018 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants