Skip to content

Add separate Calico etcd#9865

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
mgleung:calico-etcd-master
Sep 12, 2018
Merged

Add separate Calico etcd#9865
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
mgleung:calico-etcd-master

Conversation

@mgleung
Copy link
Contributor

@mgleung mgleung commented Aug 31, 2018

Add in templates for creating an optional etcd container for use with Calico. This is made available as an alternative to bringing your own etcd instance or using the OpenShift etcd.

This is a copy of #9739

@papr-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 31, 2018
@mgleung
Copy link
Contributor Author

mgleung commented Sep 11, 2018

@vrutkovs @sdodson Can I get you guys to take a look? @dmmcquay already reviewed the same PR against the release-3.10 branch. #9739

@vrutkovs
Copy link
Contributor

/ok-to-test

@openshift-ci-robot openshift-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 12, 2018
@vrutkovs
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgleung, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2018
@openshift-merge-robot openshift-merge-robot merged commit 5e9a570 into openshift:master Sep 12, 2018
@mgleung mgleung deleted the calico-etcd-master branch September 12, 2018 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants