Skip to content

Configure kube-proxy and the SDN to expose metrics.#9592

Closed
squeed wants to merge 1 commit intoopenshift:masterfrom
squeed:add-sdn-metrics-port
Closed

Configure kube-proxy and the SDN to expose metrics.#9592
squeed wants to merge 1 commit intoopenshift:masterfrom
squeed:add-sdn-metrics-port

Conversation

@squeed
Copy link

@squeed squeed commented Aug 14, 2018

Right now, kube-proxy is configured to listen on a hard-coded port on localhost that conflicts with the kubelet (now that they are separate processes). Change it to listen on an unused port.

Fixes: bz1588420

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: squeed
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: michaelgugino

If they are not already assigned, you can assign the PR to them by writing /assign @michaelgugino in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 14, 2018
Copy link
Contributor

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be patched in openshift, not the installer.

@vrutkovs
Copy link
Contributor

This does expose metrics on 11257, however openshift-monitoring doesn't scrape that target.

Also, I agree with Michael - if its a static port number it should be baked in kube-proxy

@dcbw
Copy link
Contributor

dcbw commented Dec 12, 2018

Clayton says we need to pick a port between 9000 -> 10000 that's currently unused by other things, and have our operator configure that metrics port for the SDN.

@openshift-ci-robot
Copy link

@squeed: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/gcp 00d33f3 link /test gcp
ci/prow/gcp-crio 00d33f3 link /test gcp-crio
ci/prow/e2e-aws 00d33f3 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs
Copy link
Contributor

Master branch is closed! A major refactor is ongoing in devel-40. Changes for 3.x should be made directly to the latest release branch they're relevant to and backported from there.

@vrutkovs vrutkovs closed this Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants