Set the master cluster hostname under OpenStack #7993
Conversation
openshift-ci-robot
added
the
size/S
|
@tzumainn this is pretty important. Without it, we have to set |
|
/lgtm |
| value: { get_attr: [loadbalancer, resource.0, private_ip] } | ||
| {% else %} | ||
| value: { get_attr: [masters, resource.0, private_ip] } | ||
| {% endif %} |
|
I hit an unrelated error testing this, so I think this one is fine. Thanks! |
|
/lgtm |
|
/test all |
|
Oh, so that still doesn't run the travis and atomic tests? Sigh. |
|
@tzumainn could you add your LGTM back please? I've rebased it to get the CI jobs unstuck. The code didn't change. |
|
/lgtm |
|
/retest |
|
bot, retest this please |
|
/test gcp-upgrade |
|
This is just a (clean) rebase. |
|
/lgtm |
|
bot, retest this please |
|
Hm okay so that doesn't seem to do anything when I say it. |
|
Rebased. |
Depending on the deployment (with or without a loadbalancer, with or without external DNS) the `openshift_master_cluster_hostname` may be different. And given the OpenStack's hostname suffix behaviour, it is almost never set to the right value on its own. This updates the Heat templates and the dynamic inventory to set the variable to a value that should always work and it can always be overridden in the group_vars .
|
Fixed the tox failure. |
|
@tzumainn can I have the lgtm back? The tests are all actually passing now :-). |
|
/lgtm |
6 participants
Depending on the deployment (with or without a loadbalancer, with or
without external DNS) the
openshift_master_cluster_hostnamemay bedifferent. And given the OpenStack's hostname suffix behaviour, it is
almost never set to the right value on its own.
This updates the Heat templates and the dynamic inventory to set the
variable to a value that should always work and it can always be
overridden in the group_vars .