catalog: use service serving cert for ctrl mgr & use default prometheus scrape #7925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt service endpoint scrape
openshift-ci-robot
added
the
size/M
|
/assign sdodson |
|
/retest |
|
/lgtm |
|
bot, retest this please |
|
/test gcp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
background in #7681 (review)
two issues:
This PR backs off changes from #7681. It matches changes for cluster up in openshift/origin#19286
I have not changed the Catalog API Server cert creation over to this method but I did create #7924 for tracking.