Fixed GCE playbooks so that they're more like the AWS playbooks.#688
Merged
twiest merged 1 commit intoopenshift:masterfrom Oct 14, 2015
twiest:gce
Merged
Fixed GCE playbooks so that they're more like the AWS playbooks.#688twiest merged 1 commit intoopenshift:masterfrom twiest:gce
twiest merged 1 commit intoopenshift:masterfrom
twiest:gce
Conversation
Contributor
Author
|
@menren @sdodson Hey Guys, mind looking at this please? It should only affect GCE, and I tested it using the online deployment type against GCE and everything is working well for me. @menren This is the code that enables infra nodes that I talked about in PR #658. Please make sure this doesn't break you. This is meant to make the GCE code work more like the AWS code. |
Contributor
|
As I mentionned, we need to do some check in the case we deploy without infra-node. It seems good to me with infra-node : |
Contributor
Author
|
@menren @sdodson Please review again, I've addressed all comments. @menren please also make sure it doesn't break you. I also tested with and without infra nodes. With infra nodes: Without infra nodes: |
Namely the GCE playbooks now: - Create infra nodes - Correctly label nodes in OpenShift - Setup masters as nodes as well (needed for sdn) - Removed set_infra_launch_facts_tasks.yml as it's not used anymore.
Contributor
|
Good for me ! |
Member
|
LGTM |
twiest
added a commit
that referenced
this pull request
Oct 14, 2015
Fixed GCE playbooks so that they're more like the AWS playbooks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Namely the GCE playbooks now: