Skip to content

Conversation

@michaelgugino
Copy link
Contributor

This builds off of #6784

Fix etcd-upgrade sanity checks

This commit ensures that only oo_etcd_to_config and
oo_masters_to_config are checked during sanity_checks.

This will prevent hosts that have not had facts gathered
(such as nodes) will not be processed for correct inventory
and runtime facts.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1536317

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 19, 2018
This commit ensures that only oo_etcd_to_config and
oo_masters_to_config are checked during sanity_checks.

This will prevent hosts that have not had facts gathered
(such as nodes) will not be processed for correct inventory
and runtime facts.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1536317
@michaelgugino michaelgugino force-pushed the fix-etcd-upgrade-sanity branch from 1e0e1a9 to 13614e3 Compare January 19, 2018 22:24
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 19, 2018
@sdodson
Copy link
Member

sdodson commented Jan 22, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2018
@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@sdodson sdodson merged commit c5e465c into openshift:master Jan 23, 2018
@openshift-ci-robot
Copy link

@michaelgugino: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/gcp 13614e3 link /test gcp
ci/openshift-jenkins/logging 13614e3 link /test logging
ci/openshift-jenkins/extended_conformance_install_crio 13614e3 link /test crio

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. priority/P1 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants