Drop inconsistent flannel SDN for openstack #6727
Conversation
openshift-ci-robot
added
the
needs-ok-to-test
|
Hi @bogdando. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/L
|
Can one of the admins verify this patch?
|
Flannel SDN support by openstack provider is left behind in the openshift-ansible-contribs. Restore it back, if supported in the future. Signed-off-by: Bogdan Dobrelya <bdobreli@redhat.com>
|
Tested, looks good to me! Quick question: is it just shift-on-stack that won't support flannel? There still seems to be lots of flannel code inside of openshift-ansible (although this PR removes it from the openstack sections). |
|
@tzumainn this does not remove flannel support as a feature, we'll have to reimplement it though as the code had been moved from its old repo in inconsistent state. This is to remove that inconsistency, not to drop flannel support for ever :) @tomassedovic |
bogdando
changed the title
|
@bogdando Ah, gotcha! Just out of curiosity, is there a plan for re-implementing that support? I just want to be sure that we're not removing something that we'll end up re-adding later. |
|
@bogdando: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-bot
added
the
needs-rebase
|
The documentaion part is going to be superseded by #7398 it seems |
5 participants
Flannel SDN support by openstack provider is left
behind in the openshift-ansible-contribs.
Restore it back, if supported in the future.