Add missing dependencies on openshift_facts role #6418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of these roles call the openshift_facts module but didn't include the role in their dependencies which can lead to errors in Ansible 2.4. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1524102
openshift-ci-robot
added
the
size/XS
Member
Author
|
/assign mtnbikenc michaelgugino |
Contributor
|
/lgtm |
Contributor
|
/test all [submit-queue is verifying that this PR is safe to merge] |
Member
Author
|
/retest |
Member
Author
|
/test upgrade |
Contributor
|
/test all [submit-queue is verifying that this PR is safe to merge] |
Contributor
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these roles call the openshift_facts module but didn't include
the role in their dependencies which can lead to errors in Ansible 2.4.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1524102