Remove unneeded embedded etcd logic #6414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing some remaining embedded etcd facts except for the migration plays.
openshift-ci-robot
added
the
size/M
michaelgugino
commented
Dec 8, 2017
| name: etcd | ||
| tasks_from: migrate.pre_check.yml | ||
| vars: | ||
| r_etcd_common_embedded_etcd: "{{ groups.oo_etcd_to_config | default([]) | length == 0 }}" |
Contributor
Author
There was a problem hiding this comment.
It's no longer possible for this to be set to false anywhere. If oo_etcd_to_config is len 0, evaluate_groups will fail every play.
Member
|
/retest |
Contributor
|
/test all [submit-queue is verifying that this PR is safe to merge] |
Contributor
|
Automatic merge from submit-queue. |
|
@michaelgugino: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing some remaining embedded etcd facts except
for the migration plays.