Skip to content

Fix ami building.#6373

Merged
kwoodson merged 1 commit intoopenshift:masterfrom
kwoodson:ami_build_container_runtime
Dec 7, 2017
Merged

Fix ami building.#6373
kwoodson merged 1 commit intoopenshift:masterfrom
kwoodson:ami_build_container_runtime

Conversation

@kwoodson
Copy link
Contributor

@kwoodson kwoodson commented Dec 6, 2017

With the recent refactors and moving the docker role to the container_runtime this has broken the AMI building process. The changes here calls the prerequisites in order to get the correct runtime installed.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 6, 2017
@kwoodson kwoodson requested a review from mtnbikenc December 6, 2017 14:56
@kwoodson kwoodson self-assigned this Dec 6, 2017
@ashcrow
Copy link
Member

ashcrow commented Dec 6, 2017

/test system-containers

Copy link
Member

@mtnbikenc mtnbikenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a pattern emerging here with skip_* where we need init but we don't want it all. We should discuss how we can better handle init as a whole.
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2017
@kwoodson
Copy link
Contributor Author

kwoodson commented Dec 6, 2017

Unrelated error.

        "time=\"2017-12-06T16:21:57Z\" level=fatal msg=\"Error initializing image from source docker://registry.fedoraproject.org/f26/etcd:latest: manifest unknown: manifest unknown\" "

@kwoodson
Copy link
Contributor Author

kwoodson commented Dec 6, 2017

/test system-containers

@kwoodson kwoodson merged commit 2124109 into openshift:master Dec 7, 2017
@kwoodson
Copy link
Contributor Author

/cherrypick release-3.8

@openshift-cherrypick-robot

@kwoodson: new pull request created: #6446

Details

In response to this:

/cherrypick release-3.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kwoodson kwoodson deleted the ami_build_container_runtime branch March 5, 2018 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants