Implement container_runtime playbooks and changes#6362
Implement container_runtime playbooks and changes#6362sdodson merged 1 commit intoopenshift:masterfrom
Conversation
michaelgugino
requested review from
abutcher,
giuseppe,
kwoodson,
mtnbikenc and
sdodson
openshift-ci-robot
added
the
size/XL
michaelgugino
force-pushed
the
crt-plays
branch
from
5a58f28 to
7f34281
Compare
|
/retest |
| crio_image_tag: "latest" | ||
| RedHat: | ||
| crio_image_name: "cri-o" | ||
| crio_image_tag: "{{ openshift_crio_image_tag | default(l_crt_crio_image_tag_dict[openshift_deployment_type]) }}" |
There was a problem hiding this comment.
could we simply provide the full image name here (except for RedHat where there is also the tag that changes)? The docker.io images are temporary here until we have a better place for them.
In any case, this is not blocking for me as it doesn't depend on this PR, just pointing it out that later we might revisit this part.
There was a problem hiding this comment.
Yeah, I think that's a fine idea. I wasn't sure what exactly is required for these images, seems like the variables and how we set them could use a redo.
michaelgugino
force-pushed
the
crt-plays
branch
3 times, most recently
from
e46e644 to
7e4f522
Compare
|
Witnessing some weirdness around the variable openshift_docker_use_system_container in this patch. Ansible seems to be arbitrarily assigning boolean values when this variable is evaluated. I inserted some debug statements to see what's happening and also force-casting to bool. |
michaelgugino
force-pushed
the
crt-plays
branch
from
7e4f522 to
a04f9eb
Compare
mtnbikenc
left a comment
mtnbikenc
left a comment
There was a problem hiding this comment.
Changes look good. Withholding the lgtm tag until the debugs have been removed.
michaelgugino
force-pushed
the
crt-plays
branch
from
a04f9eb to
daf9fae
Compare
|
/lgtm |
michaelgugino
force-pushed
the
crt-plays
branch
from
daf9fae to
31f0dac
Compare
michaelgugino
force-pushed
the
crt-plays
branch
from
31f0dac to
49bab75
Compare
|
As long as we have passing tests, |
This commit refactors some duplicate code, removes usage of set_fact where not needed, and reorganizes container_runtime role to use include_role.
michaelgugino
force-pushed
the
crt-plays
branch
from
49bab75 to
2249ba3
Compare
|
/lgtm cancel //PR changed after LGTM, removing LGTM. @michaelgugino @mtnbikenc |
|
@michaelgugino: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| enabled: yes | ||
| state: restarted | ||
| when: openshift_use_crio | ||
|
|
There was a problem hiding this comment.
I have to admit I don't know if the SDN code changed. As @giuseppe noted, it was added because it needed to be restarted after the sdn-ovs was installed. It's possible that sdn-ovs is installed in a different area now.
7 participants
This commit refactors some duplicate code, removes
usage of set_fact where not needed, and reorganizes
container_runtime role to use include_role.