Add possibility to enable Persistent Local Storage using Ansible #6250

dabelenda · 2017-11-24T07:27:40Z

No description provided.

rh-atomic-bot · 2017-11-24T07:29:38Z

Can one of the admins verify this patch?
I understand the following commands:

bot, add author to whitelist
bot, test pull request
bot, test pull request once

vrutkovs · 2018-01-16T12:49:07Z

playbooks/openshift-hosted/private/create_persistent_volumes.yml

+  tasks:
+  - name: Create Persistent Local Storage Classes Directories
+    file:
+      path: "/mnt/local-storage/{{ item }}"


path should be configurable

dabelenda · 2018-01-18T07:15:36Z

/test crio

vrutkovs

Looks good, although default /mnt/local-storage is defined multiple times across the playbook, it would be nice to have it set in one place only

vrutkovs · 2018-02-01T14:18:38Z

roles/openshift_persistentlocalstorage/tasks/main.yml

+                      fieldPath: metadata.namespace
+                - name: VOLUME_CONFIG_NAME
+                  value: local-volume-provisioner-config
+                image: quay.io/external_storage/local-volume-provisioner:v1.0.1


Image location and version should be parametrized

vrutkovs · 2018-02-01T14:23:42Z

inventory/hosts.example

@@ -585,6 +585,11 @@ openshift_master_identity_providers=[{'name': 'htpasswd_auth', 'login': 'true',
 # openshift_storageclass_name=gp2
 # openshift_storageclass_parameters={'type': 'gp2', 'encrypted': 'false'}
 #
+# PersistentLocalStorage


example hosts should include openshift_persistentlocalstorage_path (with default value)

dabelenda · 2018-02-19T08:24:17Z

@vrutkovs I guess the duplication of the default value comes from my inexperience with ansible, but I do not see how to reduce it further than what I already did (I removed the default value from the role. I thought that roles should be independent from the playbook and thus put the defaults there, too)

cmoulliard · 2018-04-12T11:22:49Z

Can this PR been updated, rebased and reviewed please ?

https://github.com/openshift/origin/blob/v3.9.0/examples/storage-examples/local-examples/local-storage-provisioner-template.yaml

openshift-ci-robot · 2018-05-07T15:03:27Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dabelenda
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: michaelgugino

Assign the PR to them by writing /assign @michaelgugino in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…lumes

…fined feature-gate entry for node config)

vrutkovs · 2018-05-09T08:35:34Z

/lgtm

Adapted from PR#6250 to openshift-ansible, originally authored by Diego Abelenda <[email protected]> for OpenShift Ansible 3.10. PR reference: openshift#6250

dabelenda force-pushed the add_persistentlocalvolumes branch from e5657df to 09f0291 Compare November 24, 2017 09:57

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 24, 2017

dabelenda force-pushed the add_persistentlocalvolumes branch from 226f7cf to 1d3b498 Compare November 30, 2017 09:50

dabelenda changed the title ~~[WIP] Add possibility to enable Persistent Local Storage using Ansible~~ Add possibility to enable Persistent Local Storage using Ansible Nov 30, 2017

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2017

dabelenda force-pushed the add_persistentlocalvolumes branch from 1d3b498 to 365470f Compare December 1, 2017 07:35

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 6, 2017

dabelenda force-pushed the add_persistentlocalvolumes branch 2 times, most recently from d729f66 to 18a43cd Compare December 8, 2017 09:47

openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 8, 2017

dabelenda force-pushed the add_persistentlocalvolumes branch from 18a43cd to d32950e Compare December 11, 2017 06:38

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2017

dabelenda force-pushed the add_persistentlocalvolumes branch 3 times, most recently from 15d4a67 to 474a850 Compare December 14, 2017 12:14

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 20, 2017

dabelenda force-pushed the add_persistentlocalvolumes branch from 09fa03d to af825ba Compare January 16, 2018 12:33

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2018

dabelenda mentioned this pull request Jan 16, 2018

Add support for hostpath persistent volume definitions #6022

Merged

vrutkovs reviewed Jan 16, 2018

View reviewed changes

vrutkovs reviewed Feb 1, 2018

View reviewed changes

openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2018

dabelenda force-pushed the add_persistentlocalvolumes branch from aee199e to efce631 Compare February 19, 2018 07:33

openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 19, 2018

openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 11, 2018

dabelenda force-pushed the add_persistentlocalvolumes branch from 5d81ef3 to b882647 Compare April 12, 2018 13:27

openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2018

dabelenda added 9 commits May 7, 2018 17:02

Add possibility to enable Persistent Local Storage using Ansible

8eedacf

Add default to False to avoid error when variable is not defined

c0246d9

Parametrize the path for local storage

3b3cb8f

Copy pasted too fast, "item" variable is not defined outside mkdir loop

b7390a6

Remove redundant default value definition

4e119df

Parametrize provisionner image

910d09f

Correct Undefined variable

eb3c68e

Add example for local persistent storage image and path

fab2c4c

Update daemonset to follow changes in openshift storage example:

6500d24

https://github.com/openshift/origin/blob/v3.9.0/examples/storage-examples/local-examples/local-storage-provisioner-template.yaml

dabelenda force-pushed the add_persistentlocalvolumes branch from b882647 to 6500d24 Compare May 7, 2018 15:03

dabelenda added 4 commits May 7, 2018 17:15

Modify rights to allow serviceaccount to change SELinux context of vo…

55eb551

…lumes

Use local variable instead of global one in template

6aab2ed

Enable missing feature-gate for VolumeScheduling (also use already de…

33c4938

…fined feature-gate entry for node config)

Fix other configuration for node...

1b6f97e

openshift-ci-robot assigned vrutkovs May 9, 2018

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2018

vrutkovs merged commit d8a8f1d into openshift:master May 9, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add possibility to enable Persistent Local Storage using Ansible #6250

Add possibility to enable Persistent Local Storage using Ansible #6250

dabelenda commented Nov 24, 2017

rh-atomic-bot commented Nov 24, 2017

vrutkovs Jan 16, 2018

dabelenda commented Jan 18, 2018

vrutkovs left a comment

vrutkovs Feb 1, 2018

vrutkovs Feb 1, 2018

dabelenda commented Feb 19, 2018

cmoulliard commented Apr 12, 2018

openshift-ci-robot commented May 7, 2018

vrutkovs commented May 9, 2018

Add possibility to enable Persistent Local Storage using Ansible #6250

Add possibility to enable Persistent Local Storage using Ansible #6250

Conversation

dabelenda commented Nov 24, 2017

rh-atomic-bot commented Nov 24, 2017

vrutkovs Jan 16, 2018

Choose a reason for hiding this comment

dabelenda commented Jan 18, 2018

vrutkovs left a comment

Choose a reason for hiding this comment

vrutkovs Feb 1, 2018

Choose a reason for hiding this comment

vrutkovs Feb 1, 2018

Choose a reason for hiding this comment

dabelenda commented Feb 19, 2018

cmoulliard commented Apr 12, 2018

openshift-ci-robot commented May 7, 2018

vrutkovs commented May 9, 2018