Skip to content

Add the OpenStack provider#6039

Merged
sdodson merged 1226 commits intoopenshift:masterfrom
tomassedovic:openstack-provider-githist
Nov 16, 2017
Merged

Add the OpenStack provider#6039
sdodson merged 1226 commits intoopenshift:masterfrom
tomassedovic:openstack-provider-githist

Conversation

@tomassedovic
Copy link
Contributor

This replaces the #5797. It has the same content, but preserves the git history from the openshift-ansible-contrib repo.

It uses the openstack roles and playbooks from openshift-ansible-contrib and adapts them to have the same structure as the AWS provider.

This provides a basic deployment with more advanced stuff coming in follow-up patches.

dav1x and others added 30 commits August 16, 2017 16:45
Adding OCP 3.6 files and modifications
* rolling back skip-packages

* guess can't use # lines
Mention of the role (which I don't find anywhere in the repo atm) breaks my refarch. I'd advise removing it all together.
* README, all.yml, stack_params.yaml, openstack-stack: added docker volume size customisation

- app_volume_size changed to node_volume_size (it is node everywhere else)

* all.yml, stack_params.yaml,openstack-stack: added customisation for lb, etcd, dns

* README: updated

* README: updated info about ephemeral volumes
The end to end scripts just started failing because the contents of the
tarball shipping the oc tool changed.

Since the binary is always available on the master node after a
successful deployment, let us just copy it from there.
Hoping that this will get our pull requests and code reviews more
consistent (and it should help people getting started with code
reviews).
need privilges to run non-atomic-command
* resolving #660 items

* only touch new node
adding files for 3.6 update and optimizing some rhsm
Because the templates are present in a role, the `template` module is
able to look them up directly, without having to use `{{ role_path
}}/templates`.
The `openstack_*_network_name` vars are strings, not booleans, so the
absense shouldn't really be marked by `False`.
This makes sure that all the variables used in the `openshift_openstack`
role are prefixed with `openshift_openstack_` as is the convention.
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 7, 2017
@tomassedovic
Copy link
Contributor Author

@michaelgugino @oybed @bogdando @sdodson @mbruzek FYI this is the new version of the OpenStack provider PR.

@bogdando
Copy link
Contributor

bogdando commented Nov 7, 2017

👍
let's do this!

Copy link
Contributor

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2017
@sdodson
Copy link
Member

sdodson commented Nov 7, 2017

/hold
holding this until 3.7 branch is forked tomorrow when we clear codefreeze

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2017
@tomassedovic
Copy link
Contributor Author

@sdodson I see the 3.7 release branch has been created. What's the next step here?

@bogdando
Copy link
Contributor

sorry for spamming, I better off remove the reference from the commit msg

@sdodson
Copy link
Member

sdodson commented Nov 15, 2017

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2017
@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 15, 2017

@tomassedovic: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/upgrade 2e9d134 link /test upgrade
ci/openshift-jenkins/system-containers 2e9d134 link /test system-containers

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tomassedovic
Copy link
Contributor Author

@michaelgugino I'm not sure what to make of the two failing tests. They don't seem to be related to this change. The vast majority of the files here are new and shouldn't affect the outcome of the CI.

Is there anything I should do here? Assuming this is a flakey CI, is there anything I need to do here? This pull request is no longer in the queue dashboard.

@tomassedovic
Copy link
Contributor Author

And of course if it's not a CI problem, I'm not sure where to look -- the failures doesn't seem to be related to anything here. Any ideas?

@sdodson
Copy link
Member

sdodson commented Nov 16, 2017

They both look like flakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.