Add the OpenStack provider#6039
Add the OpenStack provider#6039sdodson merged 1226 commits intoopenshift:masterfrom tomassedovic:openstack-provider-githist
Conversation
Adding OCP 3.6 files and modifications
* rolling back skip-packages * guess can't use # lines
Mention of the role (which I don't find anywhere in the repo atm) breaks my refarch. I'd advise removing it all together.
* README, all.yml, stack_params.yaml, openstack-stack: added docker volume size customisation - app_volume_size changed to node_volume_size (it is node everywhere else) * all.yml, stack_params.yaml,openstack-stack: added customisation for lb, etcd, dns * README: updated * README: updated info about ephemeral volumes
The end to end scripts just started failing because the contents of the tarball shipping the oc tool changed. Since the binary is always available on the master node after a successful deployment, let us just copy it from there.
Hoping that this will get our pull requests and code reviews more consistent (and it should help people getting started with code reviews).
need privilges to run non-atomic-command
adding files for 3.6 update and optimizing some rhsm
Merge back 3.5 support
Because the templates are present in a role, the `template` module is
able to look them up directly, without having to use `{{ role_path
}}/templates`.
The `openstack_*_network_name` vars are strings, not booleans, so the absense shouldn't really be marked by `False`.
This makes sure that all the variables used in the `openshift_openstack` role are prefixed with `openshift_openstack_` as is the convention.
|
@michaelgugino @oybed @bogdando @sdodson @mbruzek FYI this is the new version of the OpenStack provider PR. |
|
👍 |
|
/hold |
|
@sdodson I see the 3.7 release branch has been created. What's the next step here? |
|
sorry for spamming, I better off remove the reference from the commit msg |
|
/hold cancel |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
@tomassedovic: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@michaelgugino I'm not sure what to make of the two failing tests. They don't seem to be related to this change. The vast majority of the files here are new and shouldn't affect the outcome of the CI. Is there anything I should do here? Assuming this is a flakey CI, is there anything I need to do here? This pull request is no longer in the queue dashboard. |
|
And of course if it's not a CI problem, I'm not sure where to look -- the failures doesn't seem to be related to anything here. Any ideas? |
|
They both look like flakes. |
This replaces the #5797. It has the same content, but preserves the git history from the openshift-ansible-contrib repo.
It uses the openstack roles and playbooks from openshift-ansible-contrib and adapts them to have the same structure as the AWS provider.
This provides a basic deployment with more advanced stuff coming in follow-up patches.