Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blockstorage version for openstack #5776

Merged
merged 1 commit into from
Nov 6, 2017
Merged

Add blockstorage version for openstack #5776

merged 1 commit into from
Nov 6, 2017

Conversation

pearj
Copy link
Contributor

@pearj pearj commented Oct 17, 2017

When running on OpenStack pike using https://github.com/openshift/openshift-ansible-contrib/tree/master/playbooks/provisioning/openstack with OpenShift Origin 3.6 I found that when trying to use/provision cinder-volumes I got a "BS API version autodetection failed" error.

Specifying the bs-version=v2 in openstack.conf made the error go away.

@openshift-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@openshift-ci-robot
Copy link

Hi @pearj. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 17, 2017
@pearj
Copy link
Contributor Author

pearj commented Oct 17, 2017

This is related to kubernetes/website#5925

@openshift-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@michaelgugino michaelgugino self-assigned this Oct 23, 2017
michaelgugino
michaelgugino reviewed Oct 23, 2017
View reviewed changes
inventory/byo/hosts.ose.example
@@ -251,6 +251,9 @@ openshift_master_identity_providers=[{'name': 'htpasswd_auth', 'login': 'true',
#openshift_cloudprovider_openstack_region=region
#openshift_cloudprovider_openstack_lb_subnet_id=subnet_id
#
# Note: If you're getting a "BS API version autodetection failed" when provisioning cinder volumes you may need this setting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this note could be a little clearer.

Let's include the affected versions as mentioned in kubernetes/website#5925

Or perhaps we should wait to see what the approved text is from kubernetes, if that patch ships soon.

@michaelgugino
Copy link
Contributor

/ok-to-test

@pearj
Thank you for the PR. I will keep an eye on the kubernetes issue you linked and see what language they end up with.

@openshift-ci-robot openshift-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 23, 2017
@michaelgugino michaelgugino added affects_3.6 kind/bug Categorizes issue or PR as related to a bug. labels Oct 23, 2017
@michaelgugino
Copy link
Contributor

The referenced PR merged upstream.

/lgtm

/test upgrade

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2017
@michaelgugino
Copy link
Contributor

/test upgrade

@pearj
Copy link
Contributor Author

pearj commented Oct 30, 2017 •
edited
Loading

For what it’s worth I run my OpenStack with port based endpoints, so in theory according to that new k8s doco, I should be unaffected, yet I was.

When I looked at the cinder go files, I can see that in k8s 1.7 there is some auto detection, but nothing in 1.6. So that’s why I left my comment a bit vague. Otherwise, it sounds like it might be:

  • OpenStack port based endpoints < 1.7
  • OpenStack path based endpoints <= 1.8

I haven’t tried the RC of OpenShift 3.7, so I don’t actually know if it is needed in 3.7 or not.

@michaelgugino
Copy link
Contributor

@pearj Thanks for the clarification. Yeah, I think the message provides some information that will lead users to the right choice.

@michaelgugino
Copy link
Contributor

/test upgrade

3 similar comments
@michaelgugino
Copy link
Contributor

/test upgrade

@pearj
Copy link
Contributor Author

pearj commented Nov 4, 2017

/test upgrade

@michaelgugino
Copy link
Contributor

/test upgrade

@openshift-ci-robot
Copy link

@pearj: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/upgrade f04da2e link /test upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@michaelgugino michaelgugino merged commit 1b01fcb into openshift:release-3.6 Nov 6, 2017
@pearj
Copy link
Contributor Author

pearj commented Jan 4, 2018

Can we get this cherry-picked to the release-3.7 branch too? I've discovered this is broken for 3.7 as well. Should I submit a new pull request?

@michaelgugino
Copy link
Contributor

/cherrypick release-3.7

@openshift-cherrypick-robot
Copy link

@michaelgugino: #5776 failed to apply on top of branch "release-3.7":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
A	inventory/byo/hosts.origin.example
A	inventory/byo/hosts.ose.example
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): inventory/byo/hosts.origin.example deleted in HEAD and modified in Add blockstorage version for openstack. Version Add blockstorage version for openstack of inventory/byo/hosts.origin.example left in tree.
Auto-merging inventory/byo/hosts.example
Patch failed at 0001 Add blockstorage version for openstack

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pearj pearj mentioned this pull request Jan 4, 2018
Merged
@pearj
Copy link
Contributor Author

pearj commented Jan 4, 2018

I prepared a new pull request, #6611, for OpenShift 3.7

@pearj pearj deleted the blockstorage-version-3.6 branch January 4, 2018 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelgugino michaelgugino michaelgugino approved these changes

Assignees

@michaelgugino michaelgugino

Labels
affects_3.6 kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pearj @openshift-bot @openshift-ci-robot @michaelgugino @openshift-cherrypick-robot