-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing hostnames to registry cert #5178
Conversation
aos-ci-test |
[test] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🏄♂️
I've tried this out and got this error:
But maybe I didn't put the commit in the right place. Re-trying with this patch on top of master. |
Looks like we'll need to grab this line https://github.com/openshift/openshift-ansible/pull/4254/files#diff-0b82badce7fde71c589f8a59dd51230dL4 |
Yeah, testing locally real quick. |
2c2a0d9
to
ad642e2
Compare
aos-ci-test |
This fixes #5177 for me \o/. Thanks! |
aos-ci-test |
sigh puddles were busted |
aos-ci-test |
[test] |
[test] |
Evaluated for openshift ansible test up to ad642e2 |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/534/) (Base Commit: 2b07b98) (PR Branch Commit: ad642e2) |
We dropped several cert names in #4254
Fixes #5177