Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing hostnames to registry cert #5178

Merged
merged 1 commit into from
Aug 25, 2017

Conversation

sdodson
Copy link
Member

@sdodson sdodson commented Aug 23, 2017

We dropped several cert names in #4254
Fixes #5177

@sdodson sdodson requested a review from abutcher August 23, 2017 17:15
@sdodson
Copy link
Member Author

sdodson commented Aug 23, 2017

aos-ci-test

@sdodson
Copy link
Member Author

sdodson commented Aug 23, 2017

[test]

Copy link
Member

@abutcher abutcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏄‍♂️

@openshift-bot
Copy link

error: aos-ci-jenkins/OS_3.6_containerized for 2c2a0d9 (logs)

@tomassedovic
Copy link
Contributor

I've tried this out and got this error:

Failure summary:

  1. Host:     master-0.openshift.example.com
     Play:     Create Hosted Resources
     Task:     openshift_hosted : Generate self-signed docker-registry certificates
     Message:  the field 'args' has an invalid value, which appears to include a variable that is undefined. The error was: 'docker_registry_route_hostname' is undefined
               
               The error appears to have been in '/opt/stack/openshift-ansible/roles/openshift_hosted/tasks/registry/secure.yml': line 32, column 3, but may
               be elsewhere in the file depending on the exact syntax problem.
               
               The offending line appears to be:
               
               
               - name: Generate self-signed docker-registry certificates
                 ^ here

But maybe I didn't put the commit in the right place. Re-trying with this patch on top of master.

@openshift-bot
Copy link

error: aos-ci-jenkins/OS_3.6_NOT_containerized for 2c2a0d9 (logs)

@abutcher
Copy link
Member

@sdodson
Copy link
Member Author

sdodson commented Aug 23, 2017

Yeah, testing locally real quick.

@sdodson sdodson force-pushed the fix-registry-cert branch from 2c2a0d9 to ad642e2 Compare August 23, 2017 19:07
@sdodson
Copy link
Member Author

sdodson commented Aug 23, 2017

aos-ci-test

@tomassedovic
Copy link
Contributor

This fixes #5177 for me \o/.

Thanks!

@openshift-bot
Copy link

error: aos-ci-jenkins/OS_3.6_containerized for ad642e2 (logs)

@openshift-bot
Copy link

error: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for ad642e2 (logs)

@sdodson
Copy link
Member Author

sdodson commented Aug 24, 2017

aos-ci-test

@sdodson
Copy link
Member Author

sdodson commented Aug 24, 2017

sigh puddles were busted

@sdodson
Copy link
Member Author

sdodson commented Aug 25, 2017

aos-ci-test

@sdodson
Copy link
Member Author

sdodson commented Aug 25, 2017

[test]

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for ad642e2 (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_containerized, aos-ci-jenkins/OS_3.6_containerized_e2e_tests" for ad642e2 (logs)

@sdodson
Copy link
Member Author

sdodson commented Aug 25, 2017

[test]

@openshift-bot
Copy link

Evaluated for openshift ansible test up to ad642e2

@openshift-bot
Copy link

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/534/) (Base Commit: 2b07b98) (PR Branch Commit: ad642e2)

@sdodson sdodson merged commit 7e36915 into openshift:master Aug 25, 2017
@sdodson sdodson deleted the fix-registry-cert branch May 11, 2018 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants