Fix for OpenShift SDN Check #4126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch?
|
1 similar comment
|
Can one of the admins verify this patch?
|
ingvagabund
approved these changes
May 11, 2017
| @@ -8,4 +8,4 @@ os_firewall_allow: | |||
| port: 443/tcp | |||
| - service: OpenShift OVS sdn | |||
| port: 4789/udp | |||
| when: openshift.node.use_openshift_sdn | bool | |||
| when: openshift.common.use_openshift_sdn | bool | |||
There was a problem hiding this comment.
openshift-ansible]$ grep -rn "node.use_openshift_sdn"
roles/openshift_node/defaults/main.yml:11: when: openshift.node.use_openshift_sdn | boolopenshift-ansible]$ grep -rn "common.use_openshift_sdn" | wc -l
20roles/openshift_facts/library/openshift_facts.py:992: use_sdn = facts['common']['use_openshift_sdn']
roles/openshift_facts/library/openshift_facts.py:995: facts['common']['use_openshift_sdn'] = use_sdn
roles/openshift_facts/library/openshift_facts.py:2026: defaults['common'] = dict(use_openshift_sdn=True, ip=ip_addr,This is indeed a bug. Wondering why it popped up now, not much more sooner.
|
aos-ci-test |
|
[merge] |
|
Evaluated for openshift ansible merge up to 0bafbb0 |
|
continuous-integration/openshift-jenkins/merge FAILURE (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_openshift_ansible/364/) (Base Commit: 593ef65) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable used in the conditional was wrong and had to be changed to be working as intended.