Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make openshift_hosted_registry_console opt-out #3825

Closed
wants to merge 2 commits into from
Closed

Make openshift_hosted_registry_console opt-out #3825

wants to merge 2 commits into from

Conversation

sdodson
Copy link
Member

@sdodson sdodson commented Mar 31, 2017

  • rename things to openshift_hosted_registry_console_*
  • Allow opting out via openshift_hosted_cockpit_deploy=false

@sdodson sdodson requested review from abutcher and mwoodson March 31, 2017 18:58
@abutcher
Copy link
Member

abutcher commented Apr 3, 2017

aos-ci-test

abutcher
abutcher approved these changes Apr 3, 2017
View reviewed changes
Copy link
Member

@abutcher abutcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-bot
Copy link

success: aos-ci-jenkins/OS_unit_tests for bcff466 (logs)

@openshift-bot
Copy link

error: aos-ci-jenkins/OS_3.5_NOT_containerized for bcff466 (logs)

@openshift-bot
Copy link

error: aos-ci-jenkins/OS_3.4_NOT_containerized for bcff466 (logs)

@openshift-bot
Copy link

error: aos-ci-jenkins/OS_3.5_containerized for bcff466 (logs)

@openshift-bot
Copy link

error: aos-ci-jenkins/OS_3.4_containerized for bcff466 (logs)

@openshift-bot
Copy link

OpenShift Ansible Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 15, 2017
@sdodson
Copy link
Member Author

sdodson commented May 22, 2017

Looks like this work may be picked up in #4256 at least the renaming portion.

@sdodson sdodson closed this May 22, 2017
@sdodson sdodson deleted the cockpit-ui branch July 14, 2017 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abutcher abutcher abutcher approved these changes

@mwoodson mwoodson Awaiting requested review from mwoodson

Assignees
No one assigned
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdodson @abutcher @openshift-bot