Skip to content

Bug 1939605: crio: set manage_network_ns_lifecycle to true#12315

Closed
haircommander wants to merge 1 commit intoopenshift:release-3.11from
haircommander:manage-network-ns-lifecycle
Closed

Bug 1939605: crio: set manage_network_ns_lifecycle to true#12315
haircommander wants to merge 1 commit intoopenshift:release-3.11from
haircommander:manage-network-ns-lifecycle

Conversation

@haircommander
Copy link
Member

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@openshift-ci-robot
Copy link

@haircommander: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

crio: set manage_network_ns_lifecycle to true

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander haircommander changed the title crio: set manage_network_ns_lifecycle to true Bug 1939605: crio: set manage_network_ns_lifecycle to true Mar 16, 2021
@openshift-ci-robot
Copy link

@haircommander: This pull request references Bugzilla bug 1939605, which is invalid:

  • expected the bug to target the "3.11.z" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1939605: crio: set manage_network_ns_lifecycle to true

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 16, 2021
@haircommander
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 16, 2021
@openshift-ci-robot
Copy link

@haircommander: This pull request references Bugzilla bug 1939605, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (3.11.z) matches configured target release for branch (3.11.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Member Author

/hold

we'll want some validation against this to make sure we don't regress.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2021
@mtnbikenc
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mtnbikenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2021
@haircommander
Copy link
Member Author

/retest

1 similar comment
@nee1esh
Copy link

nee1esh commented Mar 22, 2021

/retest

@nee1esh
Copy link

nee1esh commented Mar 22, 2021

@haircommander are we ready to remove hold on this?

@mtnbikenc
Copy link
Member

FYI, builds are failing because of python package dependency issues. Feel free to update Dockerfile. I'm guessing upgrading pip will help some (and remove the need for some of the recent version pinning) and some python packages may need to be move to pip install because the versions in the CentOS repo are so old.

@haircommander
Copy link
Member Author

I would like to verify it's actually needed. ideally, someone would just add this line if they need it, and I don't know if it'll be worth making the change for everyone

@nee1esh
Copy link

nee1esh commented Apr 7, 2021

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 7, 2021

@haircommander: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-crio eb56cca link /test e2e-gcp-crio
ci/prow/e2e-aws eb56cca link /test e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member Author

going forward with #12316 instead

@openshift-ci-robot
Copy link

@haircommander: This pull request references Bugzilla bug 1939605. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1939605: crio: set manage_network_ns_lifecycle to true

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants