Bug 1939605: crio: set manage_network_ns_lifecycle to true#12315
Bug 1939605: crio: set manage_network_ns_lifecycle to true#12315haircommander wants to merge 1 commit intoopenshift:release-3.11from
Conversation
Signed-off-by: Peter Hunt <pehunt@redhat.com>
|
@haircommander: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@haircommander: This pull request references Bugzilla bug 1939605, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@haircommander: This pull request references Bugzilla bug 1939605, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold we'll want some validation against this to make sure we don't regress. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, mtnbikenc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
@haircommander are we ready to remove hold on this? |
|
FYI, builds are failing because of python package dependency issues. Feel free to update Dockerfile. I'm guessing upgrading |
|
I would like to verify it's actually needed. ideally, someone would just add this line if they need it, and I don't know if it'll be worth making the change for everyone |
|
/retest |
|
@haircommander: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
going forward with #12316 instead |
|
@haircommander: This pull request references Bugzilla bug 1939605. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
should fix https://bugzilla.redhat.com/show_bug.cgi?id=1939605
Signed-off-by: Peter Hunt pehunt@redhat.com