Ensure openshift_node variables adhere to naming standard.

[jstuever]

This change renames openshift_node40 to openshift_node and ensures all of the variables adhere to a standard naming convention.

https://jira.coreos.com/browse/BYOH-232

[jstuever]

/retest

[vrutkovs]

/retest

[vrutkovs]

/retest

[vrutkovs]

openshift/machine-config-operator#549 should fix scaleup regression

[mtnbikenc]

I tested this on a dev cluster successfully. I was initially concerned about the removal of files_dir because I know CI has used that heavily in the past. However, I couldn't find any current references and my scaleup succeeded.
/lgtm

/hold
Until openshift/machine-config-operator#549 or similar merges

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever, mtnbikenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [mtnbikenc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vrutkovs]

/retest

[vrutkovs]

/skip

[vrutkovs]

/retest

[vrutkovs]

/hold cancel
openshift/machine-config-operator#564 fixes it

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[vrutkovs]

Scaleup finally passes \o/

[vrutkovs]

/skip

[vrutkovs]

/retest

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[jstuever]

/retest

[mtnbikenc]

/test e2e-aws-scaleup-rhel7

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[jstuever]

/test e2e-aws-scaleup-rhel7

[stevekuznetsov]

/skip

[stevekuznetsov]

So I am not really sure how that job ever ran on this PR -- it is configured to run against master but not devel-40 -- @vrutkovs has something changed recently in your config?

[vrutkovs]

@stevekuznetsov nope, openshift/release#3125 was the only touched it. Maybe its due to a removed tag: there?

[stevekuznetsov]

No, that only changes promotion. HRM. Is this happening on all PRs?

/override ci/prow/e2e-aws-scaleup-rhel7

[openshift-ci-robot]

@stevekuznetsov: Overrode contexts on behalf of stevekuznetsov: ci/prow/e2e-aws-scaleup-rhel7

Details

In response to this:

No, that only changes promotion. HRM. Is this happening on all PRs?

/override ci/prow/e2e-aws-scaleup-rhel7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jstuever]

/hold

[jstuever]

Going to wait and merge to master after #11358

[mtnbikenc]

Keep progressing on devel-40 until we have things settled with master.
/hold cancel

[openshift-ci-robot]

@jstuever: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-scaleup-rhel7	0182505	link	/test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[mtnbikenc]

/retest

Failing tests:

[sig-cli] Kubectl Port forwarding [k8s.io] With a server listening on localhost [k8s.io] that expects a client request should support a client that connects, sends NO DATA, and disconnects [Suite:openshift/conformance/parallel] [Suite:k8s]