Enhance parse_ignition file content decoding #10732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
approved
michaelgugino
force-pushed
the
parse-ign-decode
branch
2 times, most recently
from
b63b799 to
f4fd6ea
Compare
Review of MCD/ignition code reveals that data is encoded in file contents following RFC 2397. This commit vendors in code from upstream python to support more robust parsing of this scheme.
michaelgugino
force-pushed
the
parse-ign-decode
branch
from
f4fd6ea to
6382c6e
Compare
Contributor
|
/lgtm Cherrypicked it to my CI branch and it worked |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelgugino, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review of MCD/ignition code reveals that data is encoded
in file contents following RFC 2397.
This commit vendors in code from upstream python to support
more robust parsing of this scheme.