Skip to content

devel-4.0: several fixes #10627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 4 commits into from
Nov 9, 2018
Merged

devel-4.0: several fixes #10627

openshift-merge-robot merged 4 commits into from
Nov 9, 2018

Conversation

@vrutkovs
Copy link
Contributor

@vrutkovs vrutkovs commented Nov 7, 2018

  • Fix syntax in Dockerfile
  • Set default values for new vars in openshift_gcp role
  • Install iptables-services when setting up CRI-O firewall
  • Copy auth kubeconfig from bootstrap node so that test container would use it

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 7, 2018
@vrutkovs vrutkovs requested review from sdodson and removed request for mtnbikenc November 7, 2018 16:30
@sdodson
Copy link
Member

sdodson commented Nov 7, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2018
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 7, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs vrutkovs closed this Nov 9, 2018
@vrutkovs vrutkovs reopened this Nov 9, 2018
@openshift-merge-robot openshift-merge-robot merged commit 3920c40 into openshift:devel-40 Nov 9, 2018
@vrutkovs vrutkovs mentioned this pull request Nov 9, 2018
Merged
@vrutkovs vrutkovs deleted the 40-ci-fixes branch January 5, 2019 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelgugino michaelgugino Awaiting requested review from michaelgugino

@sdodson sdodson Awaiting requested review from sdodson

Assignees

@sdodson sdodson

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vrutkovs @sdodson @openshift-ci-robot @openshift-merge-robot