-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Rework GCP playbooks to use bootkube #10587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework GCP playbooks to use bootkube #10587
Conversation
c6ca3bc to
7b10d4e
Compare
|
@eparis had mentioned not including the GCP infrastructure playbooks in openshift-ansible as they're not supported for customer use. If we move them elsewhere what's the best place to put them? release repo? origin-ci-tool repo? |
|
@sdodson I think we should stick them in test/ and be explicit about for 'test use only' |
2e6a7e3 to
a25967c
Compare
|
Decision from this morning's standup is that they'll live in openshift-ansible/test |
0a256b4 to
b6b3438
Compare
This commit adds code to add hosts to new installer cluster.
b6b3438 to
651d26c
Compare
michaelgugino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelgugino, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| copy: | ||
| content: "{{ (lookup('file', openshift_gcp_iam_service_account_keyfile ) | from_json ).private_key }}" | ||
| dest: /tmp/gce.pem | ||
| mode: 0600 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mode: 0600 was overly strict when I ran this locally (uncontainerized). Modules trying to open the file would have permission denied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patrickdillon This is possibly due to incorrect use of 'become'.
Requires
openshift_gcp_bootstrap_ignition_file- a location of bootstrap ignition file.TODO:
Port the rest of the scripted gcloud commands to ansibleThese modules are community-supported and should not be actively used
test/gcp