Skip to content

Conversation

@vrutkovs
Copy link
Contributor

@vrutkovs vrutkovs commented Nov 2, 2018

Requires openshift_gcp_bootstrap_ignition_file - a location of bootstrap ignition file.

TODO:

  • Ensure multiple masters / workers are working
  • Port the rest of the scripted gcloud commands to ansible
    These modules are community-supported and should not be actively used
  • Deprovision: remove DNS entries
  • Move playbooks to test/gcp
  • Remove hacks, FIXMEs etc.
  • Consider using google LB instead of DNS round-robin
  • Run ignition tasks as async?

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 2, 2018
@vrutkovs vrutkovs force-pushed the bootkube-gcp branch 6 times, most recently from c6ca3bc to 7b10d4e Compare November 5, 2018 17:31
@sdodson
Copy link
Member

sdodson commented Nov 5, 2018

@eparis had mentioned not including the GCP infrastructure playbooks in openshift-ansible as they're not supported for customer use. If we move them elsewhere what's the best place to put them? release repo? origin-ci-tool repo?

@michaelgugino
Copy link
Contributor

@sdodson I think we should stick them in test/ and be explicit about for 'test use only'

@vrutkovs vrutkovs force-pushed the bootkube-gcp branch 2 times, most recently from 2e6a7e3 to a25967c Compare November 6, 2018 14:39
@sdodson
Copy link
Member

sdodson commented Nov 6, 2018

Decision from this morning's standup is that they'll live in openshift-ansible/test

@vrutkovs vrutkovs force-pushed the bootkube-gcp branch 4 times, most recently from 0a256b4 to b6b3438 Compare November 6, 2018 16:29
Copy link
Contributor

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelgugino, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [michaelgugino,vrutkovs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 913347a into openshift:devel-40 Nov 6, 2018
copy:
content: "{{ (lookup('file', openshift_gcp_iam_service_account_keyfile ) | from_json ).private_key }}"
dest: /tmp/gce.pem
mode: 0600
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mode: 0600 was overly strict when I ran this locally (uncontainerized). Modules trying to open the file would have permission denied.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patrickdillon This is possibly due to incorrect use of 'become'.

@vrutkovs vrutkovs deleted the bootkube-gcp branch January 5, 2019 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants