-
Notifications
You must be signed in to change notification settings - Fork 2.3k
glusterfs: add probe script for liveness and readiness checks #10313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glusterfs: add probe script for liveness and readiness checks #10313
Conversation
This probe script is available in new containers only and thus the fallback if statement. In addition, we provide an env var that allows the user to disable the check for gluster-blockd. Signed-off-by: John Mulligan <jmulligan@redhat.com>
|
Can one of the admins verify this patch?
|
|
/ok-to-test |
|
bot, test pull request |
|
/retest |
|
I'm also testing this PR locally, will give a review once that's completed. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
jarrpa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Install runs successfully.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jarrpa, phlogistonjohn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Master branch? |
|
@sdodson Last I knew most of the roles, including the GlusterFS role, were going away for 4.0. Is this no longer the case? |
|
They should be, we'll decide today whether we want to keep opening PRs against master or not. We're just now starting on the first 4.0 work and things haven't yet diverged. |
This probe script is available in new containers only and thus
the fallback if statement. In addition, we provide an env var
that allows the user to disable the check for gluster-blockd.
Resolves BZ#1635672
Signed-off-by: John Mulligan jmulligan@redhat.com