Skip to content

Conversation

@phlogistonjohn
Copy link
Contributor

This probe script is available in new containers only and thus
the fallback if statement. In addition, we provide an env var
that allows the user to disable the check for gluster-blockd.

Resolves BZ#1635672

Signed-off-by: John Mulligan jmulligan@redhat.com

This probe script is available in new containers only and thus
the fallback if statement. In addition, we provide an env var
that allows the user to disable the check for gluster-blockd.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 3, 2018
@papr-bot
Copy link

papr-bot commented Oct 3, 2018

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@jarrpa
Copy link
Contributor

jarrpa commented Oct 3, 2018

/ok-to-test

@openshift-ci-robot openshift-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 3, 2018
@jarrpa
Copy link
Contributor

jarrpa commented Oct 3, 2018

bot, test pull request

@sdodson
Copy link
Member

sdodson commented Oct 3, 2018

/retest

@jarrpa
Copy link
Contributor

jarrpa commented Oct 3, 2018

I'm also testing this PR locally, will give a review once that's completed.

@phlogistonjohn
Copy link
Contributor Author

/retest

2 similar comments
@jarrpa
Copy link
Contributor

jarrpa commented Oct 3, 2018

/retest

@jarrpa
Copy link
Contributor

jarrpa commented Oct 3, 2018

/retest

@jarrpa jarrpa self-assigned this Oct 3, 2018
Copy link
Contributor

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Install runs successfully.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jarrpa, phlogistonjohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2018
@openshift-merge-robot openshift-merge-robot merged commit 429cf53 into openshift:release-3.11 Oct 3, 2018
@sdodson
Copy link
Member

sdodson commented Oct 3, 2018

Master branch?

@jarrpa
Copy link
Contributor

jarrpa commented Oct 4, 2018

@sdodson Last I knew most of the roles, including the GlusterFS role, were going away for 4.0. Is this no longer the case?

@sdodson
Copy link
Member

sdodson commented Oct 4, 2018

They should be, we'll decide today whether we want to keep opening PRs against master or not. We're just now starting on the first 4.0 work and things haven't yet diverged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants