Skip to content

[release-3.11] Move cluster-cidr proxy argument to the node config#10197

Closed
openshift-cherrypick-robot wants to merge 1 commit intoopenshift:release-3.11from
openshift-cherrypick-robot:cherry-pick-9863-to-release-3.11
Closed

[release-3.11] Move cluster-cidr proxy argument to the node config#10197
openshift-cherrypick-robot wants to merge 1 commit intoopenshift:release-3.11from
openshift-cherrypick-robot:cherry-pick-9863-to-release-3.11

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #9863

/assign michaelgugino

@sdodson
Copy link
Member

sdodson commented Sep 21, 2018

/lgtm
/hold
for 3.11.z

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2018
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2018
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/gcp a3fe9d2 link /test gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdodson
Copy link
Member

sdodson commented Oct 11, 2018

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2018
@sdodson
Copy link
Member

sdodson commented Oct 11, 2018

/close
This seems to be rolled up into #10233

@openshift-ci-robot
Copy link

@sdodson: Closing this PR.

Details

In response to this:

/close
This seems to be rolled up into #10233

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants