Fix Calico launch on multi-master cluster

[msheldyakov]

example error:
[0;31m Error from server (AlreadyExists): error when creating "/tmp/openshift-ansible-zAWzABP/calico.yml": clusterroles.authorization.openshift.io "calico-kube-controllers" already exists[0m
[0;31m Error from server (AlreadyExists): error when creating "/tmp/openshift-ansible-zAWzABP/calico.yml": clusterroles.authorization.openshift.io "calico-node" already exists[0m
[0;31m Error from server (AlreadyExists): error when creating "/tmp/openshift-ansible-zAWzABP/calico.yml": jobs.batch "complete-upgrade" already exists[0m
[0;31m Error from server (AlreadyExists): error when creating "/tmp/openshift-ansible-zAWzABP/calico.yml": serviceaccounts "calico-upgrade-job" already exists[0m
[0;31m Error from server (AlreadyExists): error when creating "/tmp/openshift-ansible-zAWzABP/calico.yml": serviceaccounts "calico-node" already exists[0m

[vrutkovs]

@mgleung PTAL

[vrutkovs]

/ok-to-test

[mgleung]

I am pretty surprised that you are encountering this error. Unless something has changed with the underlying Kubernetes, I thought using the apply command should account for the possibility of the resource already existing. Let me run a couple tests of my own.

[papr-bot]

Can one of the admins verify this patch?
I understand the following commands:

• bot, add author to whitelist
• bot, test pull request
• bot, test pull request once

[mgleung]

@msheldyakov I just finished my testing. I was not able to replicate your error. That being said, I do not think that making this change will cause any additional issues if we do decide to merge it. If you can, I would ask that you wait for #9863 and #9435 to be merged in since they will make some pretty large changes to Calico on OpenShift.

[vrutkovs]

Lets backport this change to 3.11 (in 3.11.z) and 3.10.z, as this change is fairly small and fixes multimaster.

In master calico branch would be reworked anyway.

/lgtm

[vrutkovs]

/cherrypick release-3.11

[openshift-cherrypick-robot]

@vrutkovs: once the present PR merges, I will cherry-pick it on top of release-3.11 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vrutkovs]

/cherrypick release-3.10

[openshift-cherrypick-robot]

@vrutkovs: once the present PR merges, I will cherry-pick it on top of release-3.10 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msheldyakov, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [vrutkovs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-cherrypick-robot]

@vrutkovs: new pull request created: #10161

Details

In response to this:

/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@vrutkovs: new pull request created: #10162

Details

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.