Skip to content

Add proper liveness and readiness checks for Calico 3.2#10018

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
mgleung:calico-update-manifest
Sep 12, 2018
Merged

Add proper liveness and readiness checks for Calico 3.2#10018
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
mgleung:calico-update-manifest

Conversation

@mgleung
Copy link
Contributor

@mgleung mgleung commented Sep 11, 2018

In Calico 3.2, new readiness checks and some changes to the liveness checks were made. This PR will update the liveness and readiness checks if the appropriate version of Calico is being used.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 11, 2018
@papr-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 11, 2018
@vrutkovs
Copy link
Contributor

/ok-to-test

@openshift-ci-robot openshift-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 12, 2018
Copy link
Contributor

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgleung, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2018
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 229b1ea into openshift:master Sep 12, 2018
@mgleung mgleung deleted the calico-update-manifest branch September 12, 2018 22:45
@mgleung
Copy link
Contributor Author

mgleung commented Sep 25, 2018

@vrutkovs would it be better to cherrypick this to the release-3.10 branch using the /cherrypick command or should I make another PR?

@vrutkovs
Copy link
Contributor

Cherrypicking should be easier

/cherrypick release-3.11

@vrutkovs
Copy link
Contributor

/cherrypick release-3.10

@openshift-cherrypick-robot

@vrutkovs: new pull request created: #10229

Details

In response to this:

Cherrypicking should be easier

/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@vrutkovs: new pull request created: #10230

Details

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mgleung
Copy link
Contributor Author

mgleung commented Oct 18, 2018

@vrutkovs can we also get this cherry-picked into release-3.9?

@vrutkovs
Copy link
Contributor

/cherrypick release-3.9

@vrutkovs
Copy link
Contributor

Oh, CI server is still down. I'll have it done soon

@vrutkovs
Copy link
Contributor

/cherrypick release-3.9

@vrutkovs
Copy link
Contributor

/cherrypick release-3.9

1 similar comment
@vrutkovs
Copy link
Contributor

/cherrypick release-3.9

@vrutkovs
Copy link
Contributor

/cherrypick release-3.9

@openshift-cherrypick-robot

@vrutkovs: new pull request created: #10666

Details

In response to this:

/cherrypick release-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants