Skip to content

WIP Infra - Support for multiple GCE projects#1

Merged
jwhonce merged 1 commit intoopenshift:masterfrom
jwhonce:wip/registry
Sep 24, 2014
Merged

WIP Infra - Support for multiple GCE projects#1
jwhonce merged 1 commit intoopenshift:masterfrom
jwhonce:wip/registry

Conversation

@jwhonce
Copy link
Contributor

@jwhonce jwhonce commented Sep 22, 2014

  • Add support for docker-registry pod

@jwhonce
Copy link
Contributor Author

jwhonce commented Sep 22, 2014

@twiest @kwoodson Please review and merge if you agree. Thanks.

cloud.rb Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we actually aren't using with_fileglob. The warning is because we use a filter expression in a loop. When looping, they want you to use the variable directly. We can't do this because we need it to be evaluated.

So it's the same warning that you get when using with_fileglob, but it's with all use of templates with loops.

Could we change this to just "Spurious warning" instead?

@twiest
Copy link
Contributor

twiest commented Sep 23, 2014

Thanks for making these changes! :)

* Add support in cloud.rb for reading configuration
* Add support for docker-registry pod
jwhonce added a commit that referenced this pull request Sep 24, 2014
WIP Infra - Support for multiple GCE projects
@jwhonce jwhonce merged commit f2e95d7 into openshift:master Sep 24, 2014
dgoodwin referenced this pull request in dgoodwin/openshift-ansible Oct 27, 2015
Pylint fixes and ignores for incoming oo-install code.
twiest pushed a commit that referenced this pull request Nov 19, 2015
small tweaks for adding docker volume for aws master hosts
@kickino kickino mentioned this pull request Apr 8, 2016
brenton added a commit that referenced this pull request Jun 9, 2016
Restore mistakenly reverted code.
timlnx referenced this pull request in timlnx/openshift-ansible Jul 21, 2016
abutcher pushed a commit that referenced this pull request Oct 4, 2016
Filterize haproxy front/backends and add method for specifying custom front/backends
jcantrill referenced this pull request in jcantrill/openshift-ansible Oct 10, 2016
krickwix pushed a commit to krickwix/openshift-ansible that referenced this pull request Sep 4, 2017
Supports configurable domain name
sdodson pushed a commit that referenced this pull request Sep 21, 2017
Update openshift-ansible-centos-paas-sig.repo
aweiteka pushed a commit to aweiteka/openshift-ansible that referenced this pull request Feb 21, 2018
openshift-merge-robot pushed a commit that referenced this pull request Jun 11, 2019
Fix timeoutSeconds in hawkular-cassandra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants