remove abrubt os.Exit calls

[anandrkskd]

Signed-off-by: anandrkskd [email protected]

What type of PR is this?
/kind bug
What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #4999

PR acceptance criteria:

• Unit test

• Integration test

• Documentation

• I have read the test guidelines

How to test changes / Special notes to the reviewer:

[valaparthvi]

Anand, the current changes lgtm, however I see a few functions where you can make similar changes, can you include them as well?
https://github.com/openshift/odo/blob/main/pkg/devfile/adapters/kubernetes/component/adapter.go#L268
https://github.com/openshift/odo/blob/main/pkg/odo/cli/component/common_push.go#L122

[anandrkskd]

/test v4.8-integration-e2e

[valaparthvi]

/retest-required

Reason - abrupt failure of both the k8s tests
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_odo/5087/pull-ci-openshift-odo-main-psi-k8s-ibmc-integration-e2e/1442418706570285056
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_odo/5087/pull-ci-openshift-odo-main-psi-kubernetes-integration-e2e/1442418706629005312

[valaparthvi]

All the context related functions in context.go should return *Context, and error and this error should be returned in order to fix this telemetry error.
The following places should return an error to be bubbled up -

1. internalCxt.resolveProject - https://github.com/openshift/odo/blob/main/pkg/odo/genericclioptions/resolve.go#L31
2. genericclioptions.GetContextFlagValue - https://github.com/openshift/odo/blob/main/pkg/odo/genericclioptions/flag.go#L34 and https://github.com/openshift/odo/blob/main/pkg/odo/genericclioptions/flag.go#L38
3. internalCxt.resolveNamespace - https://github.com/openshift/odo/blob/main/pkg/odo/genericclioptions/resolve.go#L70
   and checkProjectCreateOrDeleteOnlyOnInvalidNamespaceNoFmt - https://github.com/openshift/odo/blob/main/pkg/odo/genericclioptions/util.go#L47
4. genericclioptions.ApplyIgnore - https://github.com/openshift/odo/blob/main/pkg/odo/genericclioptions/util.go#L71
5. CheckMachineReadableOutputCommand - https://github.com/openshift/odo/blob/main/pkg/odo/genericclioptions/runnable.go#L191

Other simple and might require more work places that need fixing -

1. IsSecure - https://github.com/openshift/odo/blob/main/pkg/odo/cli/registry/util/util.go#L23
2. ComponentAllowingEmpty - https://github.com/openshift/odo/blob/main/pkg/odo/genericclioptions/context.go#L373 & https://github.com/openshift/odo/blob/main/pkg/odo/genericclioptions/context.go#L381
3. checkComponentExistsOrFail - https://github.com/openshift/odo/blob/main/pkg/odo/genericclioptions/util.go#L61

Other not so straightforward places that need fixing -

1. DevfilePush - https://github.com/openshift/odo/blob/main/pkg/odo/cli/component/devfile.go#L51
2. DisplayLog - https://github.com/openshift/odo/blob/main/pkg/util/util.go#L1281
3. HandleError - https://github.com/openshift/odo/blob/main/pkg/odo/cli/ui/common.go#L12; I am not sure whether we want to fix this or keep it as is.
4. CopyFile - https://github.com/openshift/odo/blob/main/pkg/sync/sync.go#L44

[valaparthvi]

Other not so straightforward places that need fixing -

1. DevfilePush - https://github.com/openshift/odo/blob/main/pkg/odo/cli/component/devfile.go#L51
2. DisplayLog - https://github.com/openshift/odo/blob/main/pkg/util/util.go#L1281
3. HandleError - https://github.com/openshift/odo/blob/main/pkg/odo/cli/ui/common.go#L12; I am not sure whether we want to fix this or keep it as is.

Hey @anandrkskd, @feloy suggested that we can make the following points an issue for Hacktoberfest and I think it's a good suggestion, these issues wouldn't be completely straightforward but still good enough. If you are okay with it, I will go ahead and create the issues.

[anandrkskd]

Hey @anandrkskd, @feloy suggested that we can make the following points an issue for Hacktoberfest and I think it's a good suggestion, these issues wouldn't be completely straightforward but still good enough. If you are okay with it, I will go ahead and create the issues.

Yeah sure @valaparthvi, make sense

[anandrkskd]

Test failed due to timeout error. Retesting
/test psi-kubernetes-integration-e2e

[anandrkskd]

@valaparthvi can you review this PR, I have made all the changes.
Thanks.

[valaparthvi]

There are still traces of LogErrorAndExit in https://github.com/anandrkskd/odo/blob/dev/telemetery-os-Exit-call/pkg/odo/genericclioptions/context.go, can you remove them as well?

[netlify]

✔️ Deploy Preview for odo-docusaurus-preview ready!

🔨 Explore the source changes: f673f55

🔍 Inspect the deploy log: https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6156e37fd56b9f0007f8289d

😎 Browse the preview: https://deploy-preview-5087--odo-docusaurus-preview.netlify.app

[anandrkskd]

/test psi-kubernetes-integration-e2e

[anandrkskd]

/test psi-kubernetes-integration-e2e

[anandrkskd]

/test psi-kubernetes-integration-e2e

[anandrkskd]

@valaparthvi can you /lgtm this PR, I have updated all the change requested.

[openshift-ci]

@anandrkskd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/psi-k8s-ibmc-integration-e2e	f673f55	link	false	/test psi-k8s-ibmc-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
0.0% Duplication

[valaparthvi]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: valaparthvi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [valaparthvi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment