Modifies the usage of service create, link and unlink by using separate files for Kubernetes resources #5031

mik-dass · 2021-08-31T13:06:01Z

What type of PR is this?

/kind feature

What does this PR do / why we need it:

It modifies the usage of service create, link and unlink by using separate files for Kubernetes resources.

Which issue(s) this PR fixes:

Fixes #4886

PR acceptance criteria:

Unit test
Integration test
Documentation
I have read the test guidelines

How to test changes / Special notes to the reviewer:

TBA

mik-dass · 2021-09-02T04:59:09Z

✗  Failed to start component with name "opggji". Error: Failed to create the component: error while waiting for deployment rollout: timeout while waiting for opggji-app deployment roll out

/retest

mik-dass · 2021-09-03T04:47:33Z

✗  Failed to start component with name "smspfj". Error: Failed to create the component: error while waiting for deployment rollout: timeout while waiting for smspfj-app deployment roll out

/retest

…te files for Kubernetes resources

feloy · 2021-09-14T14:48:12Z

pkg/service/service.go

+				K8sLikeComponent: devfile.K8sLikeComponent{
+					BaseComponent: devfile.BaseComponent{},
+					K8sLikeComponentLocation: devfile.K8sLikeComponentLocation{
+						Uri: filepath.Join(name + ".yaml"),


I would expect to have the uriPath contained in this Uri field

feloy · 2021-09-15T09:18:43Z

@mik-dass Could you please delete the files in kubernetes when running odo delete --all ?

netlify · 2021-09-17T07:21:13Z

✔️ Deploy Preview for odo-docusaurus-preview ready!

🔨 Explore the source changes: ccb3823

🔍 Inspect the deploy log: https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6144418c6635f0000837def9

😎 Browse the preview: https://deploy-preview-5031--odo-docusaurus-preview.netlify.app

feloy · 2021-09-17T07:35:51Z

pkg/devfile/adapters/common/utils.go

+			continue
+		}
+
+		completePath := filepath.Join(componentContext, uri)


You should test that the URI is a relative path, and not an http[s]:// URI

mik-dass · 2021-09-17T11:35:52Z

[ssh:Fedora-32-minikube] [odo] I0917 08:12:59.182670  607482 schema.go:46] validated devfile schema
[ssh:Fedora-32-minikube] [odo] I0917 08:12:59.182938  607482 validate.go:45] Successfully validated devfile sections
[ssh:Fedora-32-minikube] [odo]  ✗  open kubernetes: no such file or directory

/retest

feloy · 2021-09-17T11:37:37Z

/lgtm
/approve

openshift-ci · 2021-09-17T11:38:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [feloy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mik-dass · 2021-09-17T12:37:18Z

[odo] I0917 12:01:01.266849 70473 validate.go:45] Successfully validated devfile sections
[odo] ✗ open /tmp/698150647/kubernetes: no such file or directory

/hold

… the delete command

sonarqubecloud · 2021-09-17T14:27:49Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
22 Code Smells

No Coverage information
No Duplication information

feloy · 2021-09-17T19:02:03Z

/test psi-kubernetes-integration-e2e
/test psi-unit-test-windows

mik-dass · 2021-09-20T05:52:08Z

 Registry DefaultDevfileRegistry is not set up properly with error: Get "https://registry.stage.devfile.io/index": connection error: PROTOCOL_ERROR, please check the registry URL and credential (refer `odo registry update --help`)
[ssh:Fedora-32-minikube] [odo] 
[ssh:Fedora-32-minikube] [odo] I0917 14:28:16.256517 1853624 util.go:483] path devfile.yaml doesn't exist, skipping it
[ssh:Fedora-32-minikube] [odo] Devfile Object Validation
[ssh:Fedora-32-minikube] [odo]  •  Checking devfile existence  ...
[ssh:Fedora-32-minikube] [odo]  ✗  Checking devfile existence [27741ns]
[ssh:Fedora-32-minikube] [odo]  ⚠  Devfile component type nodejs is not suppo

/retest

feloy · 2021-09-20T07:38:15Z

/lgtm

mohammedzee1000 · 2021-09-20T09:38:07Z

/refresh

openshift-ci · 2021-09-20T09:52:49Z

@mik-dass: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/psi-k8s-ibmc-integration-e2e	`b20ee06`	link	true	`/test psi-k8s-ibmc-integration-e2e`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-09-20T10:42:24Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

mik-dass added do not review kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation labels Aug 31, 2021

mik-dass force-pushed the inlined_service_links branch from c2e759b to 0a33e93 Compare September 1, 2021 06:16

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Sep 3, 2021

mik-dass force-pushed the inlined_service_links branch from 0a33e93 to 44ae37f Compare September 3, 2021 07:48

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Sep 3, 2021

mik-dass force-pushed the inlined_service_links branch from 44ae37f to 76060ea Compare September 3, 2021 09:47

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Sep 9, 2021

mik-dass force-pushed the inlined_service_links branch from 76060ea to 98a9254 Compare September 13, 2021 07:18

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Sep 13, 2021

mik-dass force-pushed the inlined_service_links branch 2 times, most recently from 83bc177 to 75112fa Compare September 13, 2021 11:41

mik-dass changed the title ~~[WIP] Modifies the usage of service create, link and unlink by using separate files for Kubernetes resources~~ Modifies the usage of service create, link and unlink by using separate files for Kubernetes resources Sep 13, 2021

mik-dass force-pushed the inlined_service_links branch 2 times, most recently from 5f1d3ed to 24ed8af Compare September 14, 2021 06:25

Modifies the usage of service create, link and unlink by using separa…

d5897ba

…te files for Kubernetes resources

mik-dass force-pushed the inlined_service_links branch from 24ed8af to d5897ba Compare September 14, 2021 10:08

mik-dass removed the do not review label Sep 14, 2021

feloy reviewed Sep 14, 2021

View reviewed changes

Modifies the uri path to include the folder path

f0d431a

Deletes the files when all flag is used with odo delete

ccb3823

feloy reviewed Sep 17, 2021

View reviewed changes

Fixes the unit test removeDevfileURIContents

9e98024

openshift-ci bot assigned feloy Sep 17, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 17, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Sep 17, 2021

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Sep 17, 2021

Fixes the problem of non existent uri folder when all flag is used in…

b20ee06

… the delete command

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 17, 2021

mik-dass removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Sep 20, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 20, 2021

openshift-merge-robot merged commit 639084d into redhat-developer:main Sep 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modifies the usage of service create, link and unlink by using separate files for Kubernetes resources #5031

Modifies the usage of service create, link and unlink by using separate files for Kubernetes resources #5031

mik-dass commented Aug 31, 2021

mik-dass commented Sep 2, 2021

mik-dass commented Sep 3, 2021

feloy Sep 14, 2021

feloy commented Sep 15, 2021

netlify bot commented Sep 17, 2021

feloy Sep 17, 2021

mik-dass Sep 17, 2021

mik-dass commented Sep 17, 2021

feloy commented Sep 17, 2021

openshift-ci bot commented Sep 17, 2021

mik-dass commented Sep 17, 2021

sonarqubecloud bot commented Sep 17, 2021

feloy commented Sep 17, 2021

mik-dass commented Sep 20, 2021

feloy commented Sep 20, 2021

mohammedzee1000 commented Sep 20, 2021

openshift-ci bot commented Sep 20, 2021

openshift-bot commented Sep 20, 2021

Modifies the usage of service create, link and unlink by using separate files for Kubernetes resources #5031

Modifies the usage of service create, link and unlink by using separate files for Kubernetes resources #5031

Conversation

mik-dass commented Aug 31, 2021

mik-dass commented Sep 2, 2021

mik-dass commented Sep 3, 2021

feloy Sep 14, 2021

Choose a reason for hiding this comment

feloy commented Sep 15, 2021

netlify bot commented Sep 17, 2021

feloy Sep 17, 2021

Choose a reason for hiding this comment

mik-dass Sep 17, 2021

Choose a reason for hiding this comment

mik-dass commented Sep 17, 2021

feloy commented Sep 17, 2021

openshift-ci bot commented Sep 17, 2021

mik-dass commented Sep 17, 2021

sonarqubecloud bot commented Sep 17, 2021

feloy commented Sep 17, 2021

mik-dass commented Sep 20, 2021

feloy commented Sep 20, 2021

mohammedzee1000 commented Sep 20, 2021

openshift-ci bot commented Sep 20, 2021

openshift-bot commented Sep 20, 2021