Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace unrecognised vendor dependency in go mod #4012

Conversation

prietyc123
Copy link
Contributor

@prietyc123 prietyc123 commented Sep 22, 2020

What type of PR is this?

/kind failing-test

What does does this PR do / why we need it:

make goget-ginkgo fails on PSI

++ make goget-ginkgo
go: github.com/openshift/[email protected] requires
	vbom.ml/[email protected]: unrecognized import path "vbom.ml/util" (https fetch: Get https://vbom.ml/util?go-get=1: dial tcp: lookup vbom.ml on 10.11.142.1:53: no such host)
# https://go-review.googlesource.com/c/go/+/198438/
GOFLAGS='' go get github.com/onsi/ginkgo/[email protected]
go: github.com/openshift/[email protected] requires
	vbom.ml/[email protected]: unrecognized import path "vbom.ml/util" (https fetch: Get https://vbom.ml/util?go-get=1: dial tcp: lookup vbom.ml on 10.11.142.1:53: no such host)
make: *** [Makefile:109: goget-ginkgo] Error 1

vbom.ml/util repo no longer exists and supports are available github.com/fvbommel/util .

Which issue(s) this PR fixes:

Fixes NA

PR acceptance criteria:

How to test changes / Special notes to the reviewer:
Detailed log: http://jenkins.psiodo.net:8080/job/Periodics/job/odo-periodic-test/61/console

@prietyc123
Copy link
Contributor Author

Travis fails due to #4008 and gets fixed in #4010

@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

Merging #4012 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4012   +/-   ##
=======================================
  Coverage   43.17%   43.17%           
=======================================
  Files         146      146           
  Lines       12338    12338           
=======================================
  Hits         5327     5327           
  Misses       6445     6445           
  Partials      566      566           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 847b190...f3a7ac1. Read the comment docs.

Copy link
Contributor

@mohammedzee1000 mohammedzee1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 22, 2020
@cdrage
Copy link
Member

cdrage commented Sep 22, 2020

/lgtm
/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Sep 22, 2020
@openshift-merge-robot openshift-merge-robot merged commit 282daab into redhat-developer:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants