Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional verification coverage in unit test #4052

Closed
1 task
prietyc123 opened this issue Sep 28, 2020 · 4 comments
Closed
1 task

Conditional verification coverage in unit test #4052

prietyc123 opened this issue Sep 28, 2020 · 4 comments
Labels
kind/user-story An issue of user-story kind lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/Medium Nice to have issue. Getting it done before priority changes would be great.

Comments

@prietyc123
Copy link
Contributor

/kind user-story

User Story

As a QE/dev I would like to cover all the possible conditional verification in unit test rather than overloading integration file.

Acceptance Criteria

  • Unit test should be written to cover conditional verification currently we have in integration test

Tests where I observed needs to be focused.

There are some more places which needs to get updated.

@openshift-ci-robot openshift-ci-robot added the kind/user-story An issue of user-story kind label Sep 28, 2020
@prietyc123 prietyc123 added the priority/Medium Nice to have issue. Getting it done before priority changes would be great. label Sep 28, 2020
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 27, 2020
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 26, 2021
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link
Collaborator

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/user-story An issue of user-story kind lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Projects
None yet
Development

No branches or pull requests

3 participants