Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALPHA: unable to list components from default devfile registry #3747

Closed
kadel opened this issue Aug 12, 2020 · 4 comments
Closed

ALPHA: unable to list components from default devfile registry #3747

kadel opened this issue Aug 12, 2020 · 4 comments
Labels
area/registry Issues or PRs related to Devfile registries kind/bug Categorizes issue or PR as related to a bug. priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). v2 Issue or PR that applies to the v2 of odo

Comments

@kadel
Copy link
Member

kadel commented Aug 12, 2020

using odo alpha1

▶ odo version
odo v2.0.0-alpha (8b213dc09)

Trying to run odo as a first time user. So I deleted ~/.odo

▶ rm -r ~/.odo

Now when I try to list components from registry I get an error as no registry is configured.
If there is no registry configured in preference.yaml odo should automatically use our public default registry github.com/odo-devfiles/registry

▶ odo catalog list components
 ⚠  Please run 'odo registry add <registry name> <registry URL>' to add registry for listing devfile components

/kind bug
/area registry
/priority high

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/registry Issues or PRs related to Devfile registries priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). labels Aug 12, 2020
@johnmcollier
Copy link
Member

johnmcollier commented Aug 12, 2020

Similar to this, when there's no preferences file, odo registry list panics:

Johns-MacBook-Pro-3:odo johncollier$ odov2 registry list
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x241688a]

goroutine 1 [running]:
github.com/openshift/odo/pkg/odo/cli/registry.(*ListOptions).Run(0x3c43808, 0x0, 0x0)
	/home/wikus/syncthing/files/dev/go/src/github.com/openshift/odo/pkg/odo/cli/registry/list.go:58 +0x5a
github.com/openshift/odo/pkg/odo/genericclioptions.GenericRun(0x2bbb080, 0x3c43808, 0xc00065c780, 0x3c43808, 0x0, 0x0)
	/home/wikus/syncthing/files/dev/go/src/github.com/openshift/odo/pkg/odo/genericclioptions/runnable.go:31 +0x13c
github.com/openshift/odo/pkg/odo/cli/registry.NewCmdList.func1(0xc00065c780, 0x3c43808, 0x0, 0x0)
	/home/wikus/syncthing/files/dev/go/src/github.com/openshift/odo/pkg/odo/cli/registry/list.go:92 +0x5e
github.com/openshift/odo/vendor/github.com/spf13/cobra.(*Command).execute(0xc00065c780, 0x3c43808, 0x0, 0x0, 0xc00065c780, 0x3c43808)
	/home/wikus/syncthing/files/dev/go/src/github.com/openshift/odo/vendor/github.com/spf13/cobra/command.go:830 +0x2aa
github.com/openshift/odo/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xc000172280, 0x29ac5b0, 0xc00015c480, 0x2)
	/home/wikus/syncthing/files/dev/go/src/github.com/openshift/odo/vendor/github.com/spf13/cobra/command.go:914 +0x2fb
github.com/openshift/odo/vendor/github.com/spf13/cobra.(*Command).Execute(...)
	/home/wikus/syncthing/files/dev/go/src/github.com/openshift/odo/vendor/github.com/spf13/cobra/command.go:864
main.main()
	/home/wikus/syncthing/files/dev/go/src/github.com/openshift/odo/cmd/odo/odo.go:67 +0x330

What's interesting is that there's still some checks for experimental mode in the alpha branch, when the preferences file is initialized:

https://github.com/openshift/odo/blob/cea3b23f32b19b39cde7b458c742d447c37b55f4/pkg/preference/preference.go#L229

@johnmcollier
Copy link
Member

The commit here: johnmcollier@274acb7 fixes things for me

Believe @cdrage was gonna pull it into his PR #3705

@kadel
Copy link
Member Author

kadel commented Aug 18, 2020

fixed in alpha-2 release
/close

@openshift-ci-robot
Copy link
Collaborator

@kadel: Closing this issue.

In response to this:

fixed in alpha-2 release
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l rm3l added the v2 Issue or PR that applies to the v2 of odo label Jun 18, 2023
@rm3l rm3l added this to odo Project Jun 18, 2023
@rm3l rm3l moved this to Done ✅ in odo Project Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Issues or PRs related to Devfile registries kind/bug Categorizes issue or PR as related to a bug. priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). v2 Issue or PR that applies to the v2 of odo
Projects
Archived in project
Development

No branches or pull requests

4 participants