georgettica/migrate to ubi [OSD-9086] #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
georgettica
commented
Nov 21, 2021
georgettica
commented
- Bulk change
- refactor(Dockerfile): migrate to ubi
georgettica
force-pushed
the
georgettica/migrate-to-ubi
branch
2 times, most recently
from
57fabee to
eca4a20
Compare
georgettica
commented
Nov 21, 2021
georgettica
force-pushed
the
georgettica/migrate-to-ubi
branch
from
eca4a20 to
ed81558
Compare
georgettica
commented
Nov 21, 2021
georgettica
force-pushed
the
georgettica/migrate-to-ubi
branch
from
ed81558 to
af5110e
Compare
|
solved the issue, now it seems the yq binary is failing to pass a checksum 😨 |
|
currently failing on mikefarah/yq#1011 |
georgettica
force-pushed
the
georgettica/migrate-to-ubi
branch
from
af5110e to
ecd9400
Compare
georgettica
changed the title
georgettica
force-pushed
the
georgettica/migrate-to-ubi
branch
from
ecd9400 to
d57b488
Compare
openshift-ci
bot
added
the
do-not-merge/work-in-progress
georgettica
force-pushed
the
georgettica/migrate-to-ubi
branch
2 times, most recently
from
b29b793 to
6f2c1db
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
georgettica
force-pushed
the
georgettica/migrate-to-ubi
branch
from
6f2c1db to
189c6c1
Compare
georgettica
force-pushed
the
georgettica/migrate-to-ubi
branch
from
189c6c1 to
315629f
Compare
clcollins
suggested changes
Jan 18, 2022
based on security requests, moved image to UBI - the-silver-searcher - tmux have been removed as there are no longer easily accesible in microdnf gcloud has moved to use python3.6 as python3.7 is not fully used in microdnf sshuttle and fzf have been built from source as they are required and are used inside the container alot - sshuttle for tunniling across clusters - fzf for reverse search - rhash for checking YQ checksums
georgettica
force-pushed
the
georgettica/migrate-to-ubi
branch
from
315629f to
31cffbc
Compare
- use pattern of https://catalog.redhat.com/software/containers/rhel8/nodejs-16-minimal/615aefc7c739c0a4123a87e2 to install a nodejs with the latest verison - make fzf work - add vim alias for easier work
|
@clcollins sadly this change was bigger than expected.. go through it again and let me know if something else pops up for you |
clcollins
approved these changes
Jan 20, 2022
|
Builds fine, spot-checked tests are OK, builds with my backplane automation! |
|
/lgtm |
|
Great work @georgettica - thanks for sticking with it through the rough re-factor! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.