Fixes bash prompt #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems this makes the |
This fix should keep the same prompt layout and colors, but fix the non-printing character issue. Signed-off-by: Christopher Collins <[email protected]>
|
@georgettica Good catch. I think I dropped a EDIT: Scratch that. I need to do some more testing. |
clcollins
added
the
do-not-merge/hold
|
Works ok, building with no cache now to verify |
|
Works :) |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue possibly introduced in #62 caused by non-printing characters that is causing the prompt to be unaware of it's length. This is causing pasted or lines scrolled through the history to have inconsistent placement and unpredictable behavior.
This fix should keep the same prompt layout and colors, but fix the non-printing character issue.
Signed-off-by: Christopher Collins [email protected]