Fix order of basrc files being executed to avoid OCM_URL being unset #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing a minor issue of the bash prompt being blank when OCM_URL is not set in
~/.config/ocm-container/env.sourceso that the default is set to production.The current issue after this #41 change, the order of execution of the bash files leave OCM_URL being unset when starting a containe and prompt appears like this:
instead of:
This is because kube-ps1.bashrc gets executed first before ocm-container.bashrc. So the default value of OCM_URL is unset.
This PR fixes that by renaming the
.bashrcfiles by prefixing them with numbers so that their order of execution is maintained when they are executed hereI have tested this and works well for me.