Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(launch): aggregate launch-opts #110

Conversation

georgettica
Copy link
Contributor

this will allow setting the OCM_CONTAINER_LAUNCH_OPTS AND setting the -o command

additionally, you could set the -o command, AND another -o command after

this will allow setting the OCM_CONTAINER_LAUNCH_OPTS AND setting the -o command

additionally, you could set the -o command, AND another -o command after
@shibumi
Copy link

shibumi commented Mar 30, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2022
@iamkirkbater
Copy link
Contributor

Nice. +1

@georgettica georgettica merged commit ef039f8 into openshift:master Mar 30, 2022
@georgettica georgettica deleted the georgettica/allow-agregating-optional-commands branch March 30, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants