Fix PS1 so that bash new lines work consistently #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tested and it seems to work. |
clcollins
referenced
this pull request
in clcollins/ocm-container
Jan 13, 2021
feat(login): clean error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been bugging me ever since I started using ocm-container.
When you are in a container (bash) session, if your commands are really long, to the point that it extends more than the width of the current line, then bash starts overwriting your current line instead of starting in a new line.
Similar to this issue in stack overflow .
The fix is to have the colour code to start and end with
\[and\]so that bash does not count that towards the number of characters before it starts a new line.I tried to fix it with keeping the bash function but in the end this is what I came up with, which works.
Hope this makes sense!