Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(automation): add GH release updates #104

Conversation

georgettica
Copy link
Contributor

@georgettica georgettica commented Mar 18, 2022

  • Dockerfile was changed to make verifying what changed in the release easier
  • sorted github releases in dockerfile
  • added a short explanation on each binary we add

- the github action has comments to explain what is going on
- Dockerfile was changed to make verifying what changed in the release easier
- sorted github releases in dockerfile
- added a short explanation on each binary we add
- runs on a daily cronjob
@georgettica
Copy link
Contributor Author

see #104

this PR removes the github-actions

@georgettica
Copy link
Contributor Author

the slug is mostly used for me, as I have the GHA that shows the changed line, so I can copy the slug and search google for what is new in that release (instead of partially copying the URL

@georgettica
Copy link
Contributor Author

tested and compiles :)

Dockerfile Outdated
ARG VELERO_VERSION="tags/v1.7.2"
ENV VELERO_URL="https://api.github.com/repos/vmware-tanzu/velero/releases/${VELERO_VERSION}"
# the URL_SLUG is for checking the releasenotes when a version updates
ARG VELERO_VERSION="tags/v1.8.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We run 1.7 not 1.8 in OSD

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't the versions backwards compatible?

And shouldn't we upgrade then?

Anyways will downgrade :)

This will make sure that what we have in an operator will.be here
@georgettica georgettica merged commit 73dce9d into openshift:master Mar 19, 2022
@georgettica georgettica deleted the georgettica/georgettica/add-version-bump-pretty branch March 19, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants