Skip to content

Comments

[release-4.8] Bug 1974267: make oc logs work with BuildConfig's JenkinsPipeline strategy#867

Merged
openshift-ci[bot] merged 2 commits intoopenshift:release-4.8from
soltysh:bug1973643
Aug 6, 2021
Merged

[release-4.8] Bug 1974267: make oc logs work with BuildConfig's JenkinsPipeline strategy#867
openshift-ci[bot] merged 2 commits intoopenshift:release-4.8from
soltysh:bug1973643

Conversation

@soltysh
Copy link
Contributor

@soltysh soltysh commented Jun 21, 2021

This picks #863 and #860 to fix units.

/assign @atiratree

@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jun 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2021

@soltysh: This pull request references Bugzilla bug 1974267, which is invalid:

  • expected dependent Bugzilla bug 1974298 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is NEW instead
  • expected dependent Bugzilla bug 1974298 to target a release in 4.9.0, but it targets "4.6.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.8] Bug 1974267: make oc logs work with BuildConfig's JenkinsPipeline strategy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 21, 2021
@openshift-ci openshift-ci bot requested review from adambkaplan and deads2k June 21, 2021 10:16
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2021
@soltysh
Copy link
Contributor Author

soltysh commented Jun 21, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2021

@soltysh: This pull request references Bugzilla bug 1974267, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1973643 is in the state VERIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1973643 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

Requesting review from QA contact:
/cc @zhouying7780

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 21, 2021
@openshift-ci openshift-ci bot requested a review from zhouying7780 June 21, 2021 10:20
@atiratree
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Jul 22, 2021

Re-validating bugzilla status after prow config updates.
/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 22, 2021

@sdodson: This pull request references Bugzilla bug 1974267, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1973643 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1973643 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

Requesting review from QA contact:
/cc @zhouying7780

Details

In response to this:

Re-validating bugzilla status after prow config updates.
/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell
Copy link
Contributor

ecordell commented Aug 4, 2021

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

  • Score: 0.20
  • Reason: missed cutoff today, may make it tomorrow

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

1 similar comment
@ecordell
Copy link
Contributor

ecordell commented Aug 5, 2021

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

  • Score: 0.20
  • Reason: missed cutoff today, may make it tomorrow

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

@ecordell
Copy link
Contributor

ecordell commented Aug 5, 2021

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

  • Score: 0.20
  • Reason: missed cutoff for today, may make tomorrow

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

@ecordell
Copy link
Contributor

ecordell commented Aug 6, 2021

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

  • Score: 0.20
  • Reason: skipping for now, may still be tagged today

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

@ecordell
Copy link
Contributor

ecordell commented Aug 6, 2021

[patch-manager] 🚀 Approved for z-stream by score: 0.20

picked

@ecordell ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 6, 2021
@openshift-ci openshift-ci bot merged commit c6ad8ac into openshift:release-4.8 Aug 6, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 6, 2021

@soltysh: All pull requests linked via external trackers have merged:

Bugzilla bug 1974267 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.8] Bug 1974267: make oc logs work with BuildConfig's JenkinsPipeline strategy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh soltysh deleted the bug1973643 branch August 9, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants