Skip to content

Fix unit test failure #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
May 12, 2021
Merged

Fix unit test failure #821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/helpers/newapp/newapptest/newapp_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,7 +759,7 @@ func TestNewAppRunAll(t *testing.T) {
Resolvers: cmd.Resolvers{
DockerSearcher: app.DockerClientSearcher{
Client: &apptest.FakeDockerClient{
Images: []docker.APIImages{{RepoTags: []string{"centos/ruby-27-centos7"}}},
Images: []docker.APIImages{{RepoTags: []string{"quay.io/centos7/ruby-27-centos7"}}},
Copy link
Contributor

@soltysh soltysh May 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm... something still looks off, especially that we use that centos/ruby-27-centos7 image in a previous test case. I'll check it more thoroughly on Monday.

Copy link
Contributor Author

@ravisantoshgudimetla ravisantoshgudimetla May 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And as discussed yesterday on slack, this test is supposed to work well with no registry image, so you're right, I think something has changed in the response of the apiserver which is causing the problem

Copy link
Contributor

@soltysh soltysh May 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found the change that triggered this openshift/ruby-hello-world@c90a109 which makes this valid update.

Image: dockerBuilderImage(),
},
Insecure: true,
Expand Down