Remove old dependencies on dockerv1client and replace with newer equivalents #745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need this command anymore, and we can cut dependencies.
We want to use ImageRetriever from newapp to replace the old docker client. Make it easier to reuse.
Remove the references to the old logic for the docker v1 client and use image retriever instead.
openshift-ci-robot
added
the
approved
soltysh
approved these changes
Feb 22, 2021
Contributor
soltysh
left a comment
soltysh
left a comment
There was a problem hiding this comment.
/lgtm
/hold
for that docker/docker question
/retest
openshift-ci-robot
added
the
do-not-merge/hold
Move to a newer version fsouza/go-dockerclient that removes the very, very, very, very old dependencies in our tree. At this point only newapp uses the Docker API, but we want to remain as compatible as possible. It is likely this breaks compatibility with RHEL7 clients using older Docker versions and that is ok.
smarterclayton
force-pushed
the
remove_old_clients
branch
from
7cb9aa0 to
834a8d0
Compare
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
soltysh
approved these changes
Feb 25, 2021
Contributor
soltysh
left a comment
soltysh
left a comment
There was a problem hiding this comment.
/hold cancel
/lgtm
/retest
openshift-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.