Skip to content

oc adm release new: add check for the existence of profile annotations in release manifests #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
csrwng wants to merge 1 commit into from
Closed

oc adm release new: add check for the existence of profile annotations in release manifests #663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions pkg/cli/admin/release/new.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ import (
imagemanifest "github.com/openshift/oc/pkg/cli/image/manifest"
)

const profileAnnotationPrefix = "include.release.openshift.io/"

func NewNewOptions(streams genericclioptions.IOStreams) *NewOptions {
return &NewOptions{
IOStreams: streams,
Expand Down Expand Up @@ -737,6 +739,24 @@ func (o *NewOptions) Run() error {
if s, ok := m["apiVersion"].(string); !ok || s == "" {
return fmt.Errorf("%s: manifests must contain Kubernetes API objects with 'kind' and 'apiVersion' set: %s", filename, s)
}
metadata, ok := m["metadata"].(map[string]interface{})
if !ok || metadata == nil {
return fmt.Errorf("%s: missing metadata; manifests must set at least one profile annotation", filename)
}
annotations, ok := metadata["annotations"].(map[string]interface{})
if !ok || annotations == nil {
return fmt.Errorf("%s: missing annotations; manifests must set at least one profile annotation", filename)
}
hasProfileAnnotation := false
for key := range annotations {
if strings.HasPrefix(key, profileAnnotationPrefix) {
hasProfileAnnotation = true
break
}
}
if !hasProfileAnnotation {
return fmt.Errorf("%s: missing profile annotation; manifests must set at least one profile annotation", filename)
}
break
}
return nil
Expand Down