Skip to content

Conversation

@stbenjam
Copy link
Member

@stbenjam stbenjam commented Aug 15, 2019

When extracting commands from a release, the command is typically the
same as the source executable in the image, however if that is not the
case - for example, in the case of the baremetal installer (#57), oc does the
wrong thing. If the command is openshift-baremetal-installer but it
is extracted from usr/bin/openshift-installer, oc extracts the file as
openshift-installer.

When extracting commands from a release, the command is typically the
same as the source executable in the image, however if that is not the
case - for example, in the case of the baremetal installer, oc does the
wrong thing.  If the command is `openshift-baremetal-installer` but it
is extracted from `usr/bin/openshift-installer`, oc extracts the file as
openshift-installer.
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stbenjam
To complete the pull request process, please assign smarterclayton
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 15, 2019
@smarterclayton
Copy link
Contributor

Will try this out, thanks

/assign

@stbenjam
Copy link
Member Author

This is incorporated into #57, as it's become a requirement to make it all work correctly. Can re-open if prefer to review it separately

/close

@openshift-ci-robot
Copy link

@stbenjam: Closed this PR.

Details

In response to this:

This is incorporated into #57, as it's become a requirement to make it all work correctly. Can re-open if prefer to review it separately

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants