-
Notifications
You must be signed in to change notification settings - Fork 426
Bug 1878163: Updating Dockerfile.rhel baseimages to mach ocp-build-data config #572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@soltysh: This pull request references Bugzilla bug 1878163, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tnozicka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgmt
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh, tnozicka The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@soltysh: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
This MUST NOT be merged at this time. Because oc is dynamically linked, building it with a RHEL 8 builder causes it to have GLIBC_2.28 symbol dependencies which prevents it from executing on RHEL 7 and other "LTS" distros. And since we don't have a RHEL 7 golang 1.15 builder yet, this necessitates staying with 1.14 for the moment. Please close this and reconsider #571 . /hold |
|
@yselkowitz yeah that's fair. |
|
@soltysh: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@soltysh: This pull request references Bugzilla bug 1878163. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Replaces #571
fyi @yselkowitz