[release-4.19] OCPBUGS-94720,OCPBUGS-91095: Bump golang.org/x/net to openshift-sustaining/net v0.43.0-sec.2 by germanparente · Pull Request #2343 · openshift/oc

germanparente · 2026-08-04T22:40:00Z

Summary

Fixes CVE-2026-25681 (golang.org/x/net/html XSS via unexpected HTML tree rendering) on release-4.19
Uses go mod edit -replace to point golang.org/x/net to the backport fork github.com/openshift-sustaining/net@v0.43.0-sec.2, avoiding a Go toolchain bump from 1.23.0 to 1.25.0 that a direct upgrade to v0.55.0 would require
Go toolchain remains at go 1.23.0

Test plan

Verify go mod verify passes
Verify go build ./... succeeds
Verify CI passes
Confirm go mod edit -json shows the replace directive and Go version is unchanged

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> rh-pre-commit.version: 2.4.0 rh-pre-commit.check-secrets: ENABLED

openshift-merge-bot · 2026-08-04T22:40:02Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-08-04T22:40:07Z

@germanparente: This pull request references Jira Issue OCPBUGS-94720, which is invalid:

expected dependent Jira Issue OCPBUGS-91324 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Fixes CVE-2026-25681 (golang.org/x/net/html XSS via unexpected HTML tree rendering) on release-4.19

Uses go mod edit -replace to point golang.org/x/net to the backport fork github.com/openshift-sustaining/net@v0.43.0-sec.2, avoiding a Go toolchain bump from 1.23.0 to 1.25.0 that a direct upgrade to v0.55.0 would require

Go toolchain remains at go 1.23.0

Test plan

Verify go mod verify passes

Verify go build ./... succeeds

Verify CI passes

Confirm go mod edit -json shows the replace directive and Go version is unchanged

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-08-04T22:40:09Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2cbcaf80-c51c-497f-9a85-1bd3b1f5c8d0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

_{Comment @coderabbitai help to get the list of available commands.}

MrSanketkumar · 2026-08-06T10:07:21Z

/retitle [release-4.19] OCPBUGS-94720,OCPBUGS-94688: Bump golang.org/x/net to openshift-sustaining/net v0.43.0-sec.2

MrSanketkumar · 2026-08-06T10:07:59Z

/retitle [release-4.19] OCPBUGS-94720,OCPBUGS-94688: Bump golang.org/x/net to openshift-sustaining/net v0.43.0-sec.2

openshift-ci-robot · 2026-08-06T10:08:09Z

@germanparente: This pull request references Jira Issue OCPBUGS-94720, which is invalid:

expected dependent Jira Issue OCPBUGS-91324 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-94688, which is invalid:

expected the vulnerability to target either version "4.19." or "openshift-4.19.", but it targets "4.18.z" instead
expected dependent Jira Issue OCPBUGS-91095 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead
expected dependent Jira Issue OCPBUGS-91095 to target a version in 4.20.0, 4.20.z, but it targets "4.19.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Fixes CVE-2026-25681 (golang.org/x/net/html XSS via unexpected HTML tree rendering) on release-4.19

Uses go mod edit -replace to point golang.org/x/net to the backport fork github.com/openshift-sustaining/net@v0.43.0-sec.2, avoiding a Go toolchain bump from 1.23.0 to 1.25.0 that a direct upgrade to v0.55.0 would require

Go toolchain remains at go 1.23.0

Test plan

Verify go mod verify passes

Verify go build ./... succeeds

Verify CI passes

Confirm go mod edit -json shows the replace directive and Go version is unchanged

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

MrSanketkumar · 2026-08-06T10:10:22Z

/retitle [release-4.19] OCPBUGS-94720,OCPBUGS-91095: Bump golang.org/x/net to openshift-sustaining/net v0.43.0-sec.2

openshift-ci-robot · 2026-08-06T10:10:31Z

@germanparente: This pull request references Jira Issue OCPBUGS-94720, which is invalid:

expected dependent Jira Issue OCPBUGS-91324 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-91095, which is invalid:

expected dependent Jira Issue OCPBUGS-94907 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Fixes CVE-2026-25681 (golang.org/x/net/html XSS via unexpected HTML tree rendering) on release-4.19

Uses go mod edit -replace to point golang.org/x/net to the backport fork github.com/openshift-sustaining/net@v0.43.0-sec.2, avoiding a Go toolchain bump from 1.23.0 to 1.25.0 that a direct upgrade to v0.55.0 would require

Go toolchain remains at go 1.23.0

Test plan

Verify go mod verify passes

Verify go build ./... succeeds

Verify CI passes

Confirm go mod edit -json shows the replace directive and Go version is unchanged

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

germanparente · 2026-08-06T21:18:27Z

Unit test failure analysis

Both test failures are pre-existing and unrelated to the golang.org/x/net bump in this PR. Our branch does not modify any of the failing test files or their source code.

`TestNewAppRunAll/app_generation_using_context_dir`

This test expects the directory 3.1/test/rack-test-app to exist in github.com/openshift/sti-ruby, but that 3.1 directory has been removed from the repo (replaced by 3.0, 3.3, 4.0). The test hits GitHub live and the referenced path no longer exists, so it fails for everyone:

supplied context directory '3.1/test/rack-test-app' does not exist in 'https://github.com/openshift/sti-ruby'

`TestParse`

Passes locally (even with -race -count=3). No changes to pkg/helpers/source-to-image/git/url.go or url_test.go in this branch. Likely a transient CI environment issue.

/retest

MrSanketkumar · 2026-08-08T08:47:58Z

/test e2e-agent-compact-ipv4
/test e2e-agnostic-ovn-cmd
/test e2e-aws-ovn
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-aws-ovn-upgrade

MrSanketkumar · 2026-08-08T08:48:15Z

/test unit

MrSanketkumar · 2026-08-10T04:39:07Z

/retest-required

openshift-ci · 2026-08-10T07:36:40Z

@germanparente: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	`d02d993`	link	false	`/test security`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

MrSanketkumar · 2026-08-14T07:29:05Z

/test unit

MrSanketkumar · 2026-08-14T07:42:33Z

/jira refresh

openshift-ci-robot · 2026-08-14T07:42:42Z

@MrSanketkumar: This pull request references Jira Issue OCPBUGS-94720, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.z) matches configured target version for branch (4.19.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-91324 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-91324 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

This pull request references Jira Issue OCPBUGS-91095, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.z) matches configured target version for branch (4.19.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-94907 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-94907 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

germanparente · 2026-08-14T08:46:14Z

/label backport-risk-assessed

MrSanketkumar · 2026-08-14T10:45:19Z

/verified by CI

openshift-ci-robot · 2026-08-14T10:45:31Z

@MrSanketkumar: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

prabhapa · 2026-08-17T13:10:22Z

/lgtm

openshift-merge-bot · 2026-08-17T13:12:17Z

Scheduling required tests:
/test e2e-agnostic-ovn-cmd
/test e2e-aws-ovn
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-aws-ovn-upgrade

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-agent-compact-ipv4

openshift-ci · 2026-08-17T13:12:52Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: germanparente, prabhapa
Once this PR has been reviewed and has the lgtm label, please assign atiratree for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

germanparente · 2026-08-17T13:40:29Z

/label approved

since it has been lgtm

germanparente · 2026-08-18T07:10:55Z

/label approved

openshift-ci-robot · 2026-08-18T07:49:53Z

@germanparente: Jira Issue Verification Checks: Jira Issue OCPBUGS-94720
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-94720 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Jira Issue Verification Checks: Jira Issue OCPBUGS-91095
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-91095 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Summary

Fixes CVE-2026-25681 (golang.org/x/net/html XSS via unexpected HTML tree rendering) on release-4.19

Uses go mod edit -replace to point golang.org/x/net to the backport fork github.com/openshift-sustaining/net@v0.43.0-sec.2, avoiding a Go toolchain bump from 1.23.0 to 1.25.0 that a direct upgrade to v0.55.0 would require

Go toolchain remains at go 1.23.0

Test plan

Verify go mod verify passes

Verify go build ./... succeeds

Verify CI passes

Confirm go mod edit -json shows the replace directive and Go version is unchanged

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Fix for OCPBUGS-94720: CVE-2026-25681

d02d993

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> rh-pre-commit.version: 2.4.0 rh-pre-commit.check-secrets: ENABLED

openshift-ci Bot requested review from atiratree and deads2k August 4, 2026 22:40

openshift-ci Bot changed the title ~~Fix for OCPBUGS-94720: CVE-2026-25681~~ [release-4.19] OCPBUGS-94720,OCPBUGS-94688: Bump golang.org/x/net to openshift-sustaining/net v0.43.0-sec.2 Aug 6, 2026

openshift-ci Bot changed the title ~~[release-4.19] OCPBUGS-94720,OCPBUGS-94688: Bump golang.org/x/net to openshift-sustaining/net v0.43.0-sec.2~~ [release-4.19] OCPBUGS-94720,OCPBUGS-91095: Bump golang.org/x/net to openshift-sustaining/net v0.43.0-sec.2 Aug 6, 2026

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 14, 2026

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 14, 2026

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 14, 2026

openshift-ci Bot assigned bmanzari and mhanss Aug 14, 2026

openshift-ci Bot assigned pamoedom Aug 14, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 14, 2026

openshift-ci Bot assigned prabhapa Aug 17, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2026

openshift-merge-bot Bot merged commit 522f35a into openshift:release-4.19 Aug 18, 2026
14 of 15 checks passed

rhdmalone mentioned this pull request Aug 20, 2026

[release-4.19] OCPBUGS-94698: fix CVE-2026-25681 #2371

Closed

Conversation

germanparente commented Aug 4, 2026

Summary

Test plan

Uh oh!

openshift-merge-bot Bot commented Aug 4, 2026

Uh oh!

openshift-ci-robot commented Aug 4, 2026

Summary

Test plan

Uh oh!

coderabbitai Bot commented Aug 4, 2026

Review skipped

Uh oh!

MrSanketkumar commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MrSanketkumar commented Aug 6, 2026

Uh oh!

openshift-ci-robot commented Aug 6, 2026

Summary

Test plan

Uh oh!

MrSanketkumar commented Aug 6, 2026

Uh oh!

openshift-ci-robot commented Aug 6, 2026

Summary

Test plan

Uh oh!

germanparente commented Aug 6, 2026

Unit test failure analysis

TestNewAppRunAll/app_generation_using_context_dir

TestParse

Uh oh!

MrSanketkumar commented Aug 8, 2026

Uh oh!

MrSanketkumar commented Aug 8, 2026

Uh oh!

MrSanketkumar commented Aug 10, 2026

Uh oh!

openshift-ci Bot commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MrSanketkumar commented Aug 14, 2026

Uh oh!

MrSanketkumar commented Aug 14, 2026

Uh oh!

openshift-ci-robot commented Aug 14, 2026

Uh oh!

germanparente commented Aug 14, 2026

Uh oh!

MrSanketkumar commented Aug 14, 2026

Uh oh!

openshift-ci-robot commented Aug 14, 2026

Uh oh!

prabhapa commented Aug 17, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 17, 2026

Uh oh!

openshift-ci Bot commented Aug 17, 2026

Uh oh!

germanparente commented Aug 17, 2026

Uh oh!

germanparente commented Aug 18, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 18, 2026

Summary

Test plan

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

MrSanketkumar commented Aug 6, 2026 •

edited

Loading

`TestNewAppRunAll/app_generation_using_context_dir`

`TestParse`

openshift-ci Bot commented Aug 10, 2026 •

edited

Loading